-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Definition Files for Steamodded #399
Draft
GauntletGames-2086
wants to merge
37
commits into
main
Choose a base branch
from
lsp_definitions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+1,051
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Steamodded is not written in a way that allows you to comfortably run Lua LSP. A massive majority of functions do not have any indications of what they do besides name along with lacking any typing on their parameters. the LSP fails completely at finding API functions since they're either not defined in the workspace itself or are created inside tables which the LSP doesn't recognize. Lower-end computers may also run into performance issues if they throw the whole repo + Balatro + any mods into the workspace.
These definition files are the fix. The files are picked up by the LSP allowing auto-complete during object creation, typing for SMODS function parameters, and any additional warning (e.x. deprecated) required. Ideally with these files already set up, keeping them up-to-date with the repo is relatively simple and mostly low-maintenance.
How to Set Up / Test
lua_def
folder (or this whole branch) is downloaded.Lua
extension.neovim/nvim-lspconfig
add-on (or equivalent) is installed and configured to run thelua_ls
server..lua
file and.luarc.json
settings file for the lua LSP.lsp_def
folders in this directory:This should make the definition files inside
lsp_def
a part of the workspace, making any.lua
file have autocomplete for Steamodded params/functions that have been added intolsp_def
.Currently written files:
Classes:
Other
generate_card_UI
,poll_edition
, etc.). This is to ensure that mod devs don't run into errors from function params going missing because the vanilla code is heavily modified.ui.lua
file specifically)Note that these completions may still be missing fields tied to their classes, or have incomplete/missing descriptions.