-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metrics updates #1054
Metrics updates #1054
Conversation
e5be24b
to
834f7fe
Compare
/azp run Steeltoe.All |
Azure Pipelines successfully started running 1 pipeline(s). |
Kudos, SonarCloud Quality Gate passed! |
src/Management/src/EndpointBase/Metrics/Observer/EventCounterListener.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks OK to me, wouldn't be a bad idea to address the sonar issue now but isn't required in this branch
Just because no warning is produced? In that case, I'm afraid I have to disagree. In that same reasoning, it would be okay to introduce race conditions. Writing proper English is something we should do regardless of tooling. I don't expect this PR to fix all existing docs, but we should get it right from the start for new ones. There's no point in postponing. The effort is minimal and it needs to be done anyway. Postponing only makes it harder to merge to |
I get your point, and in that case my response would be different, but in this particular case we're talking about two periods that probably won't even be noticed by anybody. In the future, for trivial changes like this I think it would be nice to include the suggested change up front (when possible) for a quicker resolution |
Description
Adds metrics for clr.cpu.count
Adds an AllowList Option to only add metrics needed, as opposed to listing all unneeded metrics
for example:
Quality checklist
If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.