Fixed double parantheses (as proposed by toughengineer thanks :))

StefanKert · Jul 5, 2019 · 10838b8 · 10838b8 · yannduran · Jul 5, 2019
1 parent 8fd3995
commit 10838b8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/src/BuildVision.UI/Helpers/BuildMessagesFactory.cs b/src/BuildVision.UI/Helpers/BuildMessagesFactory.cs
@@ -58,7 +58,7 @@ private string GetTimeString(DateTime? startTime)
             }
         }
 
-        private string GetBeginAtString(BuildAction? buildAction)
+        private static string GetBeginAtString(BuildAction? buildAction)
         {
             switch (buildAction.Value)
             {
@@ -75,7 +75,7 @@ private string GetBeginAtString(BuildAction? buildAction)
             }
         }
 
-        private string GetActionName(BuildAction buildAction)
+        private static string GetActionName(BuildAction buildAction)
         {
             switch (buildAction)
             {
@@ -92,7 +92,7 @@ private string GetActionName(BuildAction buildAction)
             }
         }
 
-        private string GetUnitName(BuildScope buildScope)
+        private static string GetUnitName(BuildScope buildScope)
         {
             string unitName = "";
             switch (buildScope)
@@ -210,7 +210,7 @@ private string GetBuildDoneMajorMessage(IBuildInformationModel buildInformationM
             return resultMainString;
         }
 
-        private string GetResultName(BuildResultState resultState)
+        private static string GetResultName(BuildResultState resultState)
         {
             switch (resultState)
             {
@@ -243,9 +243,8 @@ private string GetBuildDoneExtraMessage(IBuildInformationModel buildInformationM
                 return string.Empty;
             }
 
-            TimeSpan timeSpan = buildInformationModel.BuildFinishTime.Value.Subtract(buildInformationModel.BuildStartTime.Value);
-            string extraTimePartString = GetExtraTimePartString(timeSpan);
-            return string.Format(_packageSettingsProvider.Settings.BuildMessagesSettings.ExtraMessageStringFormat, extraTimePartString);
+            var timeSpan = buildInformationModel.BuildFinishTime.Value.Subtract(buildInformationModel.BuildStartTime.Value);
+            return GetExtraTimePartString(timeSpan);
         }
 
         private string GetExtraTimePartString(TimeSpan timeSpan)

diff --git a/src/BuildVision/Services/BuildInformationProvider.cs b/src/BuildVision/Services/BuildInformationProvider.cs
@@ -50,7 +50,7 @@ public class BuildInformationProvider : IBuildInformationProvider
 
         public IBuildInformationModel BuildInformationModel { get; } = new BuildInformationModel();
         public ObservableCollection<IProjectItem> Projects { get; } = new ObservableRangeCollection<IProjectItem>();
-
+        
         [ImportingConstructor]
         public BuildInformationProvider(
             [Import(typeof(IBuildOutputLogger))] IBuildOutputLogger buildOutputLogger,