Warning label for projects with warnings is now default

StefanKert · Apr 27, 2019 · 7720135 · 7720135
1 parent a14a6fb
commit 7720135
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 11 deletions.
diff --git a/src/BuildVision.UI/Settings/GeneralSettingsControl.xaml b/src/BuildVision.UI/Settings/GeneralSettingsControl.xaml
@@ -126,10 +126,6 @@
                       Content="{x:Static res:Resources.BuildMessagesSettings_StatusBarOutputCheckBox}"
                       IsChecked="{Binding EnableStatusBarOutput}" />
 
-                <CheckBox Margin="8"
-                      Content="{x:Static res:Resources.BuildMessagesSettings_DisplayWarningSignCheckBox}"
-                      IsChecked="{Binding ShowWarningSignForBuilds}" />
-
                 <CheckBox Margin="8"
                       Content="{x:Static res:Resources.BuildMessagesSettings_HideUpToDateTargets}"
                       IsChecked="{Binding HideUpToDateTargets}" />

diff --git a/src/BuildVision.UI/Settings/Models/GeneralSettings.cs b/src/BuildVision.UI/Settings/Models/GeneralSettings.cs
@@ -14,8 +14,6 @@ public class GeneralSettings : SettingsBase
 
         public bool StopBuildAfterFirstError { get; set; }
 
-        public bool ShowWarningSignForBuilds { get; set; }
-
         public bool HideUpToDateTargets { get; set; }
 
         public NavigateToBuildFailureReasonCondition NavigateToBuildFailureReason { get; set; }
@@ -27,7 +25,6 @@ public GeneralSettings()
             BuildProgressSettings = new BuildProgressSettings();
             EnableStatusBarOutput = true;
             IndicatorsPanelVisible = true;
-            ShowWarningSignForBuilds = true;
         }
     }
 }
diff --git a/src/BuildVision.UI/ViewModels/BuildVisionPaneViewModel.cs b/src/BuildVision.UI/ViewModels/BuildVisionPaneViewModel.cs
@@ -43,7 +43,7 @@ public class BuildVisionPaneViewModel : BindableBase, IBuildVisionPaneViewModel
         private readonly IPackageSettingsProvider _settingsProvider;
         private ObservableCollection<DataGridColumn> _gridColumnsRef;
 
-        private ILogger _logger = LogManager.ForContext<BuildVisionPaneViewModel>();
+        private readonly ILogger _logger = LogManager.ForContext<BuildVisionPaneViewModel>();
 
         public ISolutionModel SolutionModel { get; set; }
 
@@ -211,8 +211,7 @@ public BuildVisionPaneViewModel(
             _settingsProvider.SettingsChanged += () =>
             {
                 OnControlSettingsChanged();
-                SyncColumnSettings();
-
+                SyncColumnSettings();  
             };
 
             if (settingsProvider.Settings.GeneralSettings.FillProjectListOnBuildBegin)

diff --git a/src/BuildVision/Services/BuildInformationProvider.cs b/src/BuildVision/Services/BuildInformationProvider.cs
@@ -301,7 +301,7 @@ private ProjectState GetProjectState(bool success, bool canceled, IProjectItem c
                 case BuildAction.RebuildAll:
                     if (success)
                     {
-                        if (_packageSettingsProvider.Settings.GeneralSettings.ShowWarningSignForBuilds && currentProject.WarningsCount > 0)
+                        if (currentProject.WarningsCount > 0)
                         {
                             projectState = ProjectState.BuildWarning;
                         }