Cleanup stuff

StefanKert · Apr 12, 2019 · 91f935e · 91f935e
1 parent 77e7aac
commit 91f935e
Show file tree

Hide file tree

Showing 44 changed files with 266 additions and 426 deletions.
diff --git a/src/BuildVision.Common/CustomStringFormatProvider.cs b/src/BuildVision.Common/CustomStringFormatProvider.cs
@@ -1,4 +1,4 @@
-using System;
+using System;
 
 namespace BuildVision.Common
 {
@@ -23,7 +23,7 @@ public string Format(string format, object arg, IFormatProvider formatProvider)
 
             if (format != null && arg is string)
             {
-                var strArg = (string) arg;
+                var strArg = (string)arg;
                 switch (format.ToUpper())
                 {
                     case "U":
@@ -34,7 +34,7 @@ public string Format(string format, object arg, IFormatProvider formatProvider)
             }
 
             return arg is IFormattable
-                       ? ((IFormattable) arg).ToString(format, formatProvider)
+                       ? ((IFormattable)arg).ToString(format, formatProvider)
                        : arg.ToString();
         }
     }

diff --git a/src/BuildVision.Common/Extensions/DateTimeExtensions.cs b/src/BuildVision.Common/Extensions/DateTimeExtensions.cs
@@ -1,8 +1,4 @@
 using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
 
 namespace BuildVision.Common.Extensions
 {

diff --git a/src/BuildVision.Common/GenericXmlSerializer.cs b/src/BuildVision.Common/GenericXmlSerializer.cs
@@ -1,5 +1,4 @@
-using System;
-using System.IO;
+using System.IO;
 using System.Text;
 using System.Xml;
 using System.Xml.Serialization;

diff --git a/src/BuildVision.Common/GithubHelper.cs b/src/BuildVision.Common/GithubHelper.cs
@@ -1,11 +1,7 @@
-using BuildVision.Common;
-using System;
-using System.Collections.Generic;
+using System;
 using System.Diagnostics;
-using System.Linq;
 using System.Net;
-using System.Text;
-using System.Threading.Tasks;
+using BuildVision.Common;
 
 namespace BuildVision.Helpers
 {

diff --git a/src/BuildVision.Common/PropertyColumnSorter.cs b/src/BuildVision.Common/PropertyColumnSorter.cs
@@ -1,8 +1,8 @@
-using BuildVision.Contracts;
-using System;
+using System;
 using System.Collections;
 using System.ComponentModel;
 using System.Reflection;
+using BuildVision.Contracts.Exceptions;
 
 namespace BuildVision.Common
 {
@@ -23,7 +23,7 @@ public PropertyColumnSorter(ListSortDirection direction, string propertyName)
 
         int IComparer.Compare(object x, object y)
         {
-            return Compare((T) x, (T) y);
+            return Compare((T)x, (T)y);
         }
 
         protected int Compare(T x, T y)

diff --git a/src/BuildVision.Contracts/BuildOutputFileTypes.cs b/src/BuildVision.Contracts/BuildOutputFileTypes.cs
@@ -1,6 +1,4 @@
-using System.Runtime.Serialization;
-
-namespace BuildVision.Contracts
+namespace BuildVision.Contracts
 {
     /// <remarks>
     /// See https://msdn.microsoft.com/en-us/library/Microsoft.VisualStudio.Shell.Interop.BuildOutputGroup.aspx
@@ -45,19 +43,13 @@ public class BuildOutputFileTypes
         /// <summary>
         /// Checks whether all properties is <c>false</c>.
         /// </summary>
-        public bool IsEmpty
-        {
-            get
-            {
-                return !(LocalizedResourceDlls
+        public bool IsEmpty => !(LocalizedResourceDlls
                             || XmlSerializer
                             || ContentFiles
                             || Built
                             || SourceFiles
                             || Symbols
                             || Documentation);
-            }
-        }
 
         public BuildOutputFileTypes()
         {

diff --git a/src/BuildVision.Contracts/Enums/BuildActions.cs b/src/BuildVision.Contracts/Enums/BuildActions.cs
@@ -1,10 +1,4 @@
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
-
-namespace BuildVision.Contracts
+namespace BuildVision.Contracts
 {
     public enum BuildActions
     {

diff --git a/...ion.Contracts/ProjectNotFoundException.cs → ...ts/Exceptions/ProjectNotFoundException.cs b/...ion.Contracts/ProjectNotFoundException.cs → ...ts/Exceptions/ProjectNotFoundException.cs
@@ -1,7 +1,7 @@
 using System;
 using System.Runtime.Serialization;
 
-namespace BuildVision.Contracts
+namespace BuildVision.Contracts.Exceptions
 {
     [Serializable]
     public class ProjectNotFoundException : Exception
@@ -22,4 +22,4 @@ protected ProjectNotFoundException(SerializationInfo info, StreamingContext cont
         {
         }
     }
-}
+}
diff --git a/...on.Contracts/PropertyNotFoundException.cs → ...s/Exceptions/PropertyNotFoundException.cs b/...on.Contracts/PropertyNotFoundException.cs → ...s/Exceptions/PropertyNotFoundException.cs
@@ -1,6 +1,6 @@
 using System;
 
-namespace BuildVision.Contracts
+namespace BuildVision.Contracts.Exceptions
 {
     public class PropertyNotFoundException : Exception
     {
@@ -14,9 +14,6 @@ public PropertyNotFoundException(string propertyName, Type type)
 
         public Type Type { get; }
 
-        public override string Message
-        {
-            get { return string.Format("Property '{0}' not found in '{1}' type.", PropertyName, Type); }
-        }
+        public override string Message => string.Format("Property '{0}' not found in '{1}' type.", PropertyName, Type);
     }
 }
diff --git a/src/BuildVision.Contracts/VisualStudioProject.cs b/src/BuildVision.Contracts/VisualStudioProject.cs
@@ -26,4 +26,4 @@ public class VisualStudioProject
         public DateTime? BuildFinishTime { get; set; }
         public TimeSpan? BuildElapsedTime { get; set; }
     }
-}
+}
diff --git a/src/BuildVision.UI/App.xaml.cs b/src/BuildVision.UI/App.xaml.cs
@@ -1,10 +1,4 @@
-using System;
-using System.Collections.Generic;
-using System.Configuration;
-using System.Data;
-using System.Linq;
-using System.Threading.Tasks;
-using System.Windows;
+using System.Windows;
 
 namespace BuildVision.UI
 {

diff --git a/src/BuildVision.UI/Attributes/DisplayStringAttribute.cs b/src/BuildVision.UI/Attributes/DisplayStringAttribute.cs
@@ -1,5 +1,4 @@
-using BuildVision.UI;
-using System;
+using System;
 
 namespace BuildVision.UI.Helpers
 {
@@ -31,15 +30,15 @@ public class DisplayStringAttribute : Attribute
         public static readonly DisplayStringAttribute Default = new DisplayStringAttribute();
         private string _resourceName;
 
-		/// <summary>
-		/// The value of this attribute.
-		/// </summary>
-		public string DisplayString { get; private set; }
+        /// <summary>
+        /// The value of this attribute.
+        /// </summary>
+        public string DisplayString { get; private set; }
 
-		public string ResourceName
+        public string ResourceName
         {
-            get { return _resourceName; }
-            set 
+            get => _resourceName;
+            set
             {
                 _resourceName = value;
                 DisplayString = Resources.ResourceManager.GetString(value, Resources.Culture);

diff --git a/src/BuildVision.UI/Attributes/GridColumnAttribute.cs b/src/BuildVision.UI/Attributes/GridColumnAttribute.cs
@@ -1,6 +1,5 @@
+using System;
 using BuildVision.Contracts;
-using BuildVision.UI;
-using System;
 
 namespace BuildVision.UI.Modelss
 {
@@ -13,23 +12,23 @@ public class GridColumnAttribute : BaseGridColumnSettingsAttribute
 
         public string ImageDictionaryUri { get; set; }
 
-		public object ExampleValue { get; set; }
+        public object ExampleValue { get; set; }
 
-		public string TimeSpanExampleValue
+        public string TimeSpanExampleValue
         {
-            get { return ""; }
-            set { ExampleValue = TimeSpan.Parse(value); }
+            get => "";
+            set => ExampleValue = TimeSpan.Parse(value);
         }
 
         public string DateTimeExampleValue
         {
-            get { return ""; }
-            set { ExampleValue = DateTime.Parse(value); }
+            get => "";
+            set => ExampleValue = DateTime.Parse(value);
         }
 
         public GridColumnAttribute(
-            string headerResourceName, 
-            ColumnsOrder displayOrder, 
+            string headerResourceName,
+            ColumnsOrder displayOrder,
             bool visible)
         {
             Header = Resources.ResourceManager.GetString(headerResourceName, Resources.Culture);

diff --git a/src/BuildVision.UI/Common/Logging/TraceManager.cs b/src/BuildVision.UI/Common/Logging/TraceManager.cs
@@ -4,8 +4,6 @@
 using System.Text;
 using System.Windows;
 
-using Microsoft.VisualStudio.Shell;
-
 namespace BuildVision.UI.Common.Logging
 {
     public static class TraceManager
@@ -102,7 +100,7 @@ public static string ToLogString(this Exception ex, string additionalMessage)
             var msg = new StringBuilder();
             if (!string.IsNullOrEmpty(additionalMessage))
                 msg.AppendLine(additionalMessage);
-    
+
             if (ex == null)
                 return msg.ToString();
-Original file line number
+Diff line change
@@ Expand Up / @@ -26,4 +26,4 @@ public class VisualStudioProject @@
             public DateTime? BuildFinishTime { get; set; }
             public TimeSpan? BuildElapsedTime { get; set; }
         }
-    }
+    }