Some minor refactorings

.editorconfig

@@ -1,138 +1,116 @@
-# editorconfig.org
-
-# top-most EditorConfig file
-root = true
-
-# Default settings:
-# A newline ending every file
-# Use 4 spaces as indentation
-[*]
-insert_final_newline = true
-indent_style = space
-indent_size = 4
-
-# C# files
-[*.cs]
-
-# "This." and "Me." Qualification
-dotnet_style_qualification_for_field = false:suggestion
-dotnet_style_qualification_for_property = false:suggestion
-dotnet_style_qualification_for_method = false:suggestion
-dotnet_style_qualification_for_event = false:suggestion
-
-# Language keywords (int, string, etc.) vs framework type names for type references
-dotnet_style_predefined_type_for_locals_parameters_members = true:suggestion
-dotnet_style_predefined_type_for_member_access = true:suggestion
-dotnet_style_object_initializer = true:suggestion
-dotnet_style_collection_initializer = true:suggestion
-dotnet_style_explicit_tuple_names = true:warning
-dotnet_style_coalesce_expression = true:suggestion
-dotnet_style_null_propagation true:warning
-
-# "var" and Explicit Types
-csharp_style_var_for_built_in_types = true:suggestion
-csharp_style_var_when_type_is_apparent = true:suggestion
-csharp_style_var_elsewhere = true:suggestion
-
-# Expression-bodied Members
-csharp_style_expression_bodied_methods = false:none
-csharp_style_expression_bodied_constructors = false:none
-csharp_style_expression_bodied_operators = false:none
-csharp_style_expression_bodied_properties = true:none
-csharp_style_expression_bodied_indexers = true:none
-csharp_style_expression_bodied_accessors = true:none
-
-# Pattern matching
-csharp_style_pattern_matching_over_is_with_cast_check = true:suggestion
-csharp_style_pattern_matching_over_as_with_null_check = true:suggestion
-csharp_style_inlined_variable_declaration = true:suggestion
-
-# Expression-level Preferences
-csharp_prefer_simple_default_expression = true:suggestion
-
-# "Null" Checking Preferences
-csharp_style_throw_expression = true:suggestion
-csharp_style_conditional_delegate_call = true:suggestion
-
-# Code Block Preferences
-csharp_prefer_braces = false:suggestion
-
-# Organize Usings
-dotnet_sort_system_directives_first = true
-
-# Newline Options
-csharp_new_line_before_open_brace = all
-csharp_new_line_before_else = true
-csharp_new_line_before_catch = true
-csharp_new_line_before_finally = true
-csharp_new_line_before_members_in_object_initializers = true
-csharp_new_line_before_members_in_anonymous_types = true
-csharp_new_line_between_query_expression_clauses = true
-
-# Indentation Options
-csharp_indent_case_contents = true
-csharp_indent_switch_labels = true
-csharp_indent_labels = no_change
-
-# Spacing Options
-csharp_space_after_cast = true
-csharp_space_between_method_declaration_parameter_list_parentheses = false
-csharp_space_between_method_call_parameter_list_parentheses = false
-csharp_space_between_parentheses = false
-
-# Wrapping Options
-csharp_preserve_single_line_statements = false
-csharp_preserve_single_line_blocks = true
-
-#####
-# Naming Convention (Custom)
-#####
-
-## Name all private fields with camelCase
-dotnet_naming_symbols.private_field_symbol.applicable_kinds = field
-dotnet_naming_symbols.private_field_symbol.applicable_accessibilities = private
-dotnet_naming_style.private_field_style.capitalization = camel_case
-dotnet_naming_rule.private_fields_are_camel_case.severity = warning
-dotnet_naming_rule.private_fields_are_camel_case.symbols = private_field_symbol
-dotnet_naming_rule.private_fields_are_camel_case.style = private_field_style
-
-## Name all non-private fields with PascalCase
-dotnet_naming_symbols.non_private_field_symbol.applicable_kinds = field
-dotnet_naming_symbols.non_private_field_symbol.applicable_accessibilities = public,internal,friend,protected,protected_internal,protected_friend
-dotnet_naming_style.non_private_field_style.capitalization = pascal_case
-dotnet_naming_rule.non_private_fields_are_pascal_case.severity = error
-dotnet_naming_rule.non_private_fields_are_pascal_case.symbols = non_private_field_symbol
-dotnet_naming_rule.non_private_fields_are_pascal_case.style = non_private_field_style
-
-## Names of parameters must be CamelCase
-dotnet_naming_symbols.parameter_symbol.applicable_kinds = parameter
-dotnet_naming_style.parameter_style.capitalization = camel_case
-dotnet_naming_rule.parameters_are_camel_case.severity = error
-dotnet_naming_rule.parameters_are_camel_case.symbols = parameter_symbol
-dotnet_naming_rule.parameters_are_camel_case.style = parameter_style
-
-## Non-interface types must use PascalCase
-dotnet_naming_symbols.non_interface_type_symbol.applicable_kinds = class,struct,enum,delegate
-dotnet_naming_style.non_interface_type_style.capitalization = pascal_case
-dotnet_naming_rule.non_interface_types_are_pascal_case.severity = error
-dotnet_naming_rule.non_interface_types_are_pascal_case.symbols = non_interface_type_symbol
-dotnet_naming_rule.non_interface_types_are_pascal_case.style = non_interface_type_style
-
-## Interfaces must use PascalCase and start with a prefix of 'I'
-dotnet_naming_symbols.interface_type_symbol.applicable_kinds = interface
-dotnet_naming_style.interface_type_style.capitalization = pascal_case
-dotnet_naming_style.interface_type_style.required_prefix = I
-dotnet_naming_rule.interface_types_must_be_prefixed_with_I.severity = error
-dotnet_naming_rule.interface_types_must_be_prefixed_with_I.symbols = interface_type_symbol
-dotnet_naming_rule.interface_types_must_be_prefixed_with_I.style = interface_type_style
-
-## Methods, Properties, and Events must use PascalCase
-dotnet_naming_symbols.member_symbol.applicable_kinds = method,property,event
-dotnet_naming_style.member_style.capitalization = pascal_case
-dotnet_naming_rule.members_are_pascal_case.severity = error
-dotnet_naming_rule.members_are_pascal_case.symbols = member_symbol
-dotnet_naming_rule.members_are_pascal_case.style = member_style
-
-# Xml project files
-[*.{csproj,vcxproj,vcxproj.filters,proj,nativeproj,locproj}]
-indent_size = 2
+# To learn more about .editorconfig see https://aka.ms/editorconfigdocs
+############################### 
+# Core EditorConfig Options   # 
+############################### 
+# All files 
+[*] 
+indent_style = space 
+# Code files 
+[*.{cs,csx,vb,vbx}] 
+indent_size = 4 
+insert_final_newline = true 
+charset = utf-8-bom 
+############################### 
+# .NET Coding Conventions     # 
+############################### 
+[*.{cs,vb}] 
+# Organize usings 
+dotnet_sort_system_directives_first = true 
+# this. preferences 
+dotnet_style_qualification_for_field = false:suggestion 
+dotnet_style_qualification_for_property = false:suggestion 
+dotnet_style_qualification_for_method = false:suggestion 
+dotnet_style_qualification_for_event = false:suggestion 
+# Language keywords vs BCL types preferences 
+dotnet_style_predefined_type_for_locals_parameters_members = true:suggestion 
+dotnet_style_predefined_type_for_member_access = true:suggestion 
+# Parentheses preferences 
+dotnet_style_parentheses_in_arithmetic_binary_operators = always_for_clarity:silent 
+dotnet_style_parentheses_in_relational_binary_operators = always_for_clarity:silent 
+dotnet_style_parentheses_in_other_binary_operators = always_for_clarity:silent 
+dotnet_style_parentheses_in_other_operators = never_if_unnecessary:silent 
+# Modifier preferences 
+dotnet_style_require_accessibility_modifiers = for_non_interface_members:silent 
+dotnet_style_readonly_field = true:suggestion 
+# Expression-level preferences 
+dotnet_style_object_initializer = true:suggestion 
+dotnet_style_collection_initializer = true:suggestion 
+dotnet_style_explicit_tuple_names = true:suggestion 
+dotnet_style_null_propagation = true:suggestion 
+dotnet_style_coalesce_expression = true:suggestion 
+dotnet_style_prefer_is_null_check_over_reference_equality_method = true:suggestion 
+dotnet_prefer_inferred_tuple_names = true:suggestion 
+dotnet_prefer_inferred_anonymous_type_member_names = true:suggestion 
+dotnet_style_prefer_auto_properties = true:silent 
+dotnet_style_prefer_conditional_expression_over_assignment = true:suggestion 
+dotnet_style_prefer_conditional_expression_over_return = true:suggestion 
+############################### 
+# Naming Conventions          # 
+############################### 
+# Style Definitions 
+dotnet_naming_style.pascal_case_style.capitalization             = pascal_case 
+# Use PascalCase for constant fields   
+dotnet_naming_rule.constant_fields_should_be_pascal_case.severity = warning 
+dotnet_naming_rule.constant_fields_should_be_pascal_case.symbols  = constant_fields 
+dotnet_naming_symbols.constant_fields.applicable_kinds            = field 
+dotnet_naming_symbols.constant_fields.applicable_accessibilities  = * 
+dotnet_naming_symbols.constant_fields.required_modifiers          = const 
+############################### 
+# C# Coding Conventions       # 
+############################### 
+[*.cs] 
+# var preferences 
+csharp_style_var_for_built_in_types = true:silent 
+csharp_style_var_when_type_is_apparent = true:suggestion 
+csharp_style_var_elsewhere = true:silent 
+# Expression-bodied members 
+csharp_style_expression_bodied_methods = false:silent 
+csharp_style_expression_bodied_constructors = false:silent 
+csharp_style_expression_bodied_operators = false:silent 
+csharp_style_expression_bodied_properties = true:silent 
+csharp_style_expression_bodied_indexers = true:silent 
+csharp_style_expression_bodied_accessors = true:silent 
+# Pattern matching preferences 
+csharp_style_pattern_matching_over_is_with_cast_check = true:suggestion 
+csharp_style_pattern_matching_over_as_with_null_check = true:suggestion 
+# Null-checking preferences 
+csharp_style_throw_expression = true:suggestion 
+csharp_style_conditional_delegate_call = true:suggestion 
+# Modifier preferences 
+csharp_preferred_modifier_order = public,private,protected,internal,static,extern,new,virtual,abstract,sealed,override,readonly,unsafe,volatile,async:suggestion 
+# Expression-level preferences 
+csharp_prefer_braces = true:suggestion 
+csharp_style_deconstructed_variable_declaration = true:suggestion 
+csharp_prefer_simple_default_expression = true:suggestion 
+csharp_style_pattern_local_over_anonymous_function = true:suggestion 
+csharp_style_inlined_variable_declaration = true:suggestion 
+############################### 
+# C# Formatting Rules         # 
+############################### 
+# New line preferences 
+csharp_new_line_before_open_brace = all 
+csharp_new_line_before_else = true 
+csharp_new_line_before_catch = true 
+csharp_new_line_before_finally = true 
+csharp_new_line_before_members_in_object_initializers = true 
+csharp_new_line_before_members_in_anonymous_types = true 
+csharp_new_line_between_query_expression_clauses = true 
+# Indentation preferences 
+csharp_indent_case_contents = true 
+csharp_indent_switch_labels = true 
+csharp_indent_labels = flush_left 
+# Space preferences 
+csharp_space_after_cast = false 
+csharp_space_after_keywords_in_control_flow_statements = true 
+csharp_space_between_method_call_parameter_list_parentheses = false 
+csharp_space_between_method_declaration_parameter_list_parentheses = false 
+csharp_space_between_parentheses = false 
+csharp_space_before_colon_in_inheritance_clause = true 
+csharp_space_after_colon_in_inheritance_clause = true 
+csharp_space_around_binary_operators = before_and_after 
+csharp_space_between_method_declaration_empty_parameter_list_parentheses = false 
+csharp_space_between_method_call_name_and_opening_parenthesis = false 
+csharp_space_between_method_call_empty_parameter_list_parentheses = false 
+# Wrapping preferences 
+csharp_preserve_single_line_statements = true 
+csharp_preserve_single_line_blocks = true 

src/BuildVision.Common/BuildVision.Common.csproj

@@ -63,7 +63,6 @@
     <Compile Include="Properties\AssemblyInfo.cs" />
     <Compile Include="PropertyColumnSorter.cs" />
     <Compile Include="RelayCommand.cs" />
-    <Compile Include="ViewCommandEventArgs.cs" />
     <Compile Include="BindableBase.cs" />
     <Compile Include="VSVersion.cs" />
   </ItemGroup>

src/BuildVision.Common/VSVersion.cs

@@ -8,7 +8,6 @@ public static class VsVersion
     {
         static readonly object mLock = new object();
         static Version mVsVersion;
-        static Version mOsVersion;
 
         public static Version FullVersion
         {
@@ -44,21 +43,5 @@ public static Version FullVersion
                 return mVsVersion;
             }
         }
-
-        public static Version OSVersion => mOsVersion ?? (mOsVersion = Environment.OSVersion.Version);
-
-        public static bool VS2012OrLater => FullVersion >= new Version(11, 0);
-
-        public static bool VS2010OrLater => FullVersion >= new Version(10, 0);
-
-        public static bool VS2008OrOlder => FullVersion < new Version(9, 0);
-
-        public static bool VS2005 => FullVersion.Major == 8;
-
-        public static bool VS2008 => FullVersion.Major == 9;
-
-        public static bool VS2010 => FullVersion.Major == 10;
-
-        public static bool VS2012 => FullVersion.Major == 11;
     }
 }

src/BuildVision.Contracts/BuildErrorRaisedEventArgs.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using BuildVision.UI.Models;
 
 namespace BuildVision.Contracts