Resolved most of the warnings in codefactor

StefanKert · Apr 27, 2019 · f4de254 · f4de254
1 parent ea508d5
commit f4de254
Show file tree

Hide file tree

Showing 13 changed files with 5 additions and 26 deletions.
diff --git a/src/BuildVision.Common/Properties/GlobalSuppressions.cs b/src/BuildVision.Common/Properties/GlobalSuppressions.cs
@@ -1,9 +1,6 @@
-
-// This file is used by Code Analysis to maintain SuppressMessage 
+// This file is used by Code Analysis to maintain SuppressMessage 
 // attributes that are applied to this project.
 // Project-level suppressions either have no target or are given 
 // a specific target and scoped to a namespace, type, member, etc.
-
 [assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Globalization", "CA1305:Specify IFormatProvider", Justification = "<Pending>", Scope = "member", Target = "~M:BuildVision.Common.FilePathHelper.ShortenPath(System.String,System.Int32)~System.String")]
-
 [assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1031:Do not catch general exception types", Justification = "<Pending>", Scope = "member", Target = "~M:BuildVision.Common.Diagnostics.SessionTelemetry.#ctor")]
diff --git a/src/BuildVision.Contracts/Properties/GlobalSuppressions.cs b/src/BuildVision.Contracts/Properties/GlobalSuppressions.cs
@@ -1,8 +1,5 @@
-
-// This file is used by Code Analysis to maintain SuppressMessage 
+// This file is used by Code Analysis to maintain SuppressMessage 
 // attributes that are applied to this project.
 // Project-level suppressions either have no target or are given 
 // a specific target and scoped to a namespace, type, member, etc.
-
 [assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Globalization", "CA1305:Specify IFormatProvider", Justification = "<Pending>", Scope = "member", Target = "~P:BuildVision.Contracts.Exceptions.PropertyNotFoundException.Message")]
-
diff --git a/src/BuildVision.UI/Converters/StateIconKeyToIconConverter.cs b/src/BuildVision.UI/Converters/StateIconKeyToIconConverter.cs
@@ -25,4 +25,3 @@ public object ConvertBack(object value, Type targetType, object parameter, Cultu
         }
     }
 }
-
diff --git a/src/BuildVision.UI/Properties/GlobalSuppressions.cs b/src/BuildVision.UI/Properties/GlobalSuppressions.cs
@@ -1,9 +1,7 @@
-
-// This file is used by Code Analysis to maintain SuppressMessage 
+// This file is used by Code Analysis to maintain SuppressMessage 
 // attributes that are applied to this project.
 // Project-level suppressions either have no target or are given 
 // a specific target and scoped to a namespace, type, member, etc.
-
 [assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Globalization", "CA1305:Specify IFormatProvider", Justification = "<Pending>", Scope = "member", Target = "~F:BuildVision.UI.Components.SpinnerControl.FormattedValuePropertyKey")]
 [assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Globalization", "CA1305:Specify IFormatProvider", Justification = "<Pending>", Scope = "member", Target = "~F:BuildVision.UI.Extensions.VectorResources._baseUri")]
 [assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Globalization", "CA1305:Specify IFormatProvider", Justification = "<Pending>", Scope = "member", Target = "~M:BuildVision.UI.Converters.DataGridLengthStringConverter.Convert(System.Object,System.Type,System.Object,System.Globalization.CultureInfo)~System.Object")]
@@ -25,7 +23,6 @@
 [assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Globalization", "CA1305:Specify IFormatProvider", Justification = "<Pending>", Scope = "member", Target = "~P:BuildVision.UI.Settings.Models.BuildMessagesSettings.DateTimeFormat")]
 [assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Globalization", "CA1305:Specify IFormatProvider", Justification = "<Pending>", Scope = "member", Target = "~P:BuildVision.UI.Settings.Models.BuildMessagesSettings.ExtraMessageStringFormat")]
 [assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Globalization", "CA1305:Specify IFormatProvider", Justification = "<Pending>", Scope = "member", Target = "~P:BuildVision.UI.Settings.Models.BuildMessagesSettings.TimeSpanFormat")]
-
 [assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1031:Do not catch general exception types", Justification = "<Pending>", Scope = "member", Target = "~M:BuildVision.UI.Converters.DataGridLengthStringConverter.ConvertBack(System.Object,System.Type,System.Object,System.Globalization.CultureInfo)~System.Object")]
 [assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1031:Do not catch general exception types", Justification = "<Pending>", Scope = "member", Target = "~M:BuildVision.UI.Converters.GridColumnSettingsToColumnExampleValueConverter.FormatExample(System.Object,System.String)~System.String")]
 [assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1031:Do not catch general exception types", Justification = "<Pending>", Scope = "member", Target = "~M:BuildVision.UI.Converters.MultiBindingStringFormatConverter.Convert(System.Object[],System.Type,System.Object,System.Globalization.CultureInfo)~System.Object")]

diff --git a/src/BuildVision/Core/BuildVisionPackage.cs b/src/BuildVision/Core/BuildVisionPackage.cs
@@ -58,7 +58,6 @@ public sealed class BuildVisionPackage : AsyncPackage, IVsPackageDynamicToolOwne
         private ILogger _logger = LogManager.ForContext<BuildVisionPackage>();
         public static ToolWindowPane ToolWindowPane { get; set; }
 
-
         public ControlSettings ControlSettings { get; set; }
 
         public BuildVisionPackage()

diff --git a/src/BuildVision/Core/SolutionBuildEvents.cs b/src/BuildVision/Core/SolutionBuildEvents.cs
@@ -9,7 +9,6 @@
 
 namespace BuildVision.Core
 {
-
     public class SolutionBuildEvents : IVsUpdateSolutionEvents2, IVsUpdateSolutionEvents4
     {
         private readonly ISolutionProvider _solutionProvider;

diff --git a/src/BuildVision/Helpers/ProjectExtensions.cs b/src/BuildVision/Helpers/ProjectExtensions.cs
@@ -510,7 +510,6 @@ public static bool IsDirty(this Project project)
             return false;
         }
 
-
         public static string GetTreePath(this Project project, bool includeSelfProjectName = true)
         {
             var path = new StringBuilder();

diff --git a/src/BuildVision/Helpers/SolutionProjectsExtensions.cs b/src/BuildVision/Helpers/SolutionProjectsExtensions.cs
@@ -104,7 +104,6 @@ public static IList<ProjectItem> GetProjectItems(this Solution solution)
                 LogManager.ForContext<Solution>().Error(ex, "Failed to get projectitems for solution {FullName}", solution?.FullName);
             }
 
-
             var projectItems = new List<ProjectItem>(dteProjects.Count);
             foreach (var project in dteProjects)
             {

diff --git a/src/BuildVision/Properties/GlobalSuppressions.cs b/src/BuildVision/Properties/GlobalSuppressions.cs
@@ -1,13 +1,10 @@
-
-// This file is used by Code Analysis to maintain SuppressMessage 
+// This file is used by Code Analysis to maintain SuppressMessage 
 // attributes that are applied to this project.
 // Project-level suppressions either have no target or are given 
 // a specific target and scoped to a namespace, type, member, etc.
-
 [assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Globalization", "CA1305:Specify IFormatProvider", Justification = "<Pending>", Scope = "member", Target = "~M:BuildVision.Helpers.ProjectExtensions.GetFrameworkString(EnvDTE.Project)~System.String")]
 [assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Globalization", "CA1305:Specify IFormatProvider", Justification = "<Pending>", Scope = "member", Target = "~M:BuildVision.Helpers.ProjectExtensions.GetProjectTypeFromRegistry(System.String,System.String)~System.String")]
 [assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Globalization", "CA1305:Specify IFormatProvider", Justification = "<Pending>", Scope = "member", Target = "~M:BuildVision.Tool.Building.BuildService.GetCopyBuildOutputFilesToClipboardActionMessage(System.String,System.String[])~System.String")]
-
 [assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1031:Do not catch general exception types", Justification = "<Pending>", Scope = "member", Target = "~M:BuildVision.Core.BuildInformationProvider.BuildOutputLogger_OnErrorRaised(BuildVision.UI.Contracts.BuildProjectContextEntry,System.Object,BuildVision.Contracts.ErrorLevel)")]
 [assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1031:Do not catch general exception types", Justification = "<Pending>", Scope = "member", Target = "~M:BuildVision.Core.BuildInformationProvider.ProjectBuildStarted(BuildVision.UI.Models.IProjectItem,BuildVision.Contracts.BuildAction)")]
 [assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1031:Do not catch general exception types", Justification = "<Pending>", Scope = "member", Target = "~M:BuildVision.Core.SolutionProvider.RefrehSolutionModel")]

diff --git a/src/BuildVision/Services/BuildService.cs b/src/BuildVision/Services/BuildService.cs
@@ -20,7 +20,6 @@
 using Microsoft.VisualStudio.Shell;
 using Serilog;
 using BuildVision.Extensions;
-using BuildVision.Core;
 
 namespace BuildVision.Tool.Building
 {
@@ -105,7 +104,6 @@ public void RaiseCommandForSelectedProject(IProjectItem selectedProjectItem, int
             }
         }
 
-
         private void RaiseCommand(VSConstants.VSStd97CmdID command)
         {
             try

diff --git a/src/BuildVision/Services/TaskBarInfoService.cs b/src/BuildVision/Services/TaskBarInfoService.cs
@@ -40,7 +40,7 @@ public void UpdateTaskBarInfo(BuildState buildState, BuildScope buildScope, int
                 return;
             }
 
-            _taskbarItemInfo.Value.ProgressState = buildState.ToTaskBarItemProgressState(buildScope); ;
+            _taskbarItemInfo.Value.ProgressState = buildState.ToTaskBarItemProgressState(buildScope);
 
             if (projectsCount <= 0)
             {

diff --git a/src/BuildVision/Views/Settings/GeneralSettingsDialogPage.cs b/src/BuildVision/Views/Settings/GeneralSettingsDialogPage.cs
@@ -2,7 +2,6 @@
 using BuildVision.UI.Settings.Models;
 using System.Runtime.InteropServices;
 
-
 namespace BuildVision.Views.Settings
 {
     [ClassInterface(ClassInterfaceType.AutoDual)]

diff --git a/test/BuildVision.UnitTests/Helpers/BuildMessageEventArgsExtensionsTests.cs b/test/BuildVision.UnitTests/Helpers/BuildMessageEventArgsExtensionsTests.cs
@@ -45,4 +45,3 @@ public void IsUserMessage_ShouldReturn_False_If_ForCombinations(LoggerVerbosity
         }
     }
 }
-
Original file line number	Diff line number	Diff line change
Expand Up		@@ -25,4 +25,3 @@ public object ConvertBack(object value, Type targetType, object parameter, Cultu
		}
		}
		}
-Original file line number
+Diff line change
@@ Expand Up / @@ -9,7 +9,6 @@ @@
     namespace BuildVision.Core
     {
         public class SolutionBuildEvents : IVsUpdateSolutionEvents2, IVsUpdateSolutionEvents4
         {
             private readonly ISolutionProvider _solutionProvider;
@@ Expand Down @@
Original file line number	Diff line number	Diff line change
Expand Up		@@ -45,4 +45,3 @@ public void IsUserMessage_ShouldReturn_False_If_ForCombinations(LoggerVerbosity
		}
		}
		}