2024 updates #54
Merged
2024 updates #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: + Akola Group + Infortar + KN Energies - Klaipėdos nafta - Linas Agro Group ~ Tallinna Kaubamaja Grupp -> TKM Grupp ~ Grigeo -> Grigeo Group
StenAL
force-pushed
the
2024
branch
22 times, most recently
from
73996b6 to
656b846
Compare
The production server is running IPv6-only and has been broken for a while because by default, Docker refuses to do IPv6 networking. This can be fixed by adding a custom network to the compose file. Java will still try to use IPv6, but this can be worked around by setting the _JAVA_OPTIONS environment variable.
The previous types were lying a bit: by having e.g. KeyStats extend Record<ColumnId, ...> TypeScript it to have all the properties of ColumnId, even though it only had some of them. Also, instead of copy-pasting definitions from the backend types to RenderedData, it is now built from TS utility types to remove potential for errors. This enabled removing some copy-pasting in App.tsx where the rendered data was being created. It also required some extra casts in Reducer.ts's compareStocksByAttribute method. Also, instead of filtering the stocks list to ensure the compared property exists (which now had type errors), the comparison method handles `undefined` values properly.
Nothing too noteworthy. MariaDB removed mysql compatibility symlinks in v11 so now Docker compose files need to use mariadbd instead of mysqld as the entrypoint.
This avoids a bunch of manual one-time set-up for the server, e.g. installing Docker and creating a systemd service. This also removes a dependency on some third party GitHub actions.
This avoids a bunch of manual one-time set-up for the server, e.g. installing and configuring Nginx. This also removes a dependency on some third party GitHub actions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken because GitHub runners don't support IPv6: actions/runner-images#668