Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functionality to invoke jktebop tasks #2

Open
SteveOv opened this issue Jan 20, 2025 · 0 comments
Open

Add functionality to invoke jktebop tasks #2

SteveOv opened this issue Jan 20, 2025 · 0 comments
Assignees
@SteveOv
Labels
enhancement New feature or request

Comments

@SteveOv
Copy link
Owner

SteveOv commented Jan 20, 2025

Functionality exists in the traininglib module of the ebop_maven repo. Review & revise while porting this over to here.
@SteveOv SteveOv added the enhancement New feature or request label Jan 20, 2025
@SteveOv SteveOv self-assigned this Jan 20, 2025
SteveOv added a commit that referenced this issue Jan 21, 2025
@SteveOv
initial version of low-level jktebop module (relates to #2)
9ba84a4
@SteveOv SteveOv pinned this issue Jan 21, 2025
SteveOv added a commit that referenced this issue Jan 21, 2025
@SteveOv
refactored out separate execute_async func (relates to #2)
b308968
SteveOv added a commit that referenced this issue Jan 21, 2025
@SteveOv
make out_file optional (relates to #2)
63be06a
SteveOv added a commit that referenced this issue Jan 21, 2025
@SteveOv
making as start on Tasks with Task2 (relates to #2)
0702bcf 
Tasks are wrappers of the jktebop module with high level functions and support for templated in files.
SteveOv added a commit that referenced this issue Jan 22, 2025
@SteveOv
better attr naming and more tests (relates to #2)
42f90f7
SteveOv added a commit that referenced this issue Jan 22, 2025
@SteveOv
fixed cleanup on tests (relates to #2)
5853d06
SteveOv added a commit that referenced this issue Jan 22, 2025
@SteveOv
support for templates with defaults (relates to #2)
4be242c 
TemplateEx class extends string.Template with support for default values (in the form ${name|default}) which are stripped out on loading. Use this functionality for Task2.
SteveOv added a commit that referenced this issue Jan 23, 2025
@SteveOv
refined TemplateEx and added tests (relates to #2)
d8abbc9
SteveOv added a commit that referenced this issue Jan 23, 2025
@SteveOv
revised Task to reflect refinements to TemplateEx (relates to #2)
e5e9050
SteveOv added a commit that referenced this issue Jan 24, 2025
@SteveOv
refactored Task to better support new Tasks (relates to #2)
ac40cda 
Reworked Task base class so that it just publishes a single run() function which does the basic job of creating an input file and synchronously running jktebop then optionally reading the output file and cleaning down any files. This should work well for up coming Tasks 3, 8 & 9 and also works for the existing Task2 with a simple override to handle using a temp file. Updated the tests and task2 template.
SteveOv added a commit that referenced this issue Jan 24, 2025
@SteveOv
removed tests now handled by test_templateex (relates to #2)
2935bf6
SteveOv added a commit that referenced this issue Jan 24, 2025
@SteveOv
added specific test for base Task.run() (relates to #2)
8920319
SteveOv added a commit that referenced this issue Jan 24, 2025
@SteveOv
added new Task3 Task and tests (relates to #2)
523642b
SteveOv added a commit that referenced this issue Jan 24, 2025
@SteveOv
added new Task8 and test (relates to #2)
21a407b
SteveOv added a commit that referenced this issue Jan 24, 2025
@SteveOv
added Task9 and test (relates to #2)
57e5700
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SteveOv SteveOv

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

jktebop SteveOv/deblib
1 participant
@SteveOv