Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WANPPPC service_type #257

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Conversation

unconnected
Copy link
Contributor

Fix for issue #256

@StevenLooman
Copy link
Owner

You'll need to create a Towncrier/change file to fix the CI, as described at: https://github.com/StevenLooman/async_upnp_client/blob/development/README.rst?plain=1#L76

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 6.25000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 71.97%. Comparing base (bfe1843) to head (ffd639b).
Report is 2 commits behind head on development.

Files with missing lines Patch % Lines
async_upnp_client/profiles/igd.py 6.25% 15 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #257      +/-   ##
===============================================
- Coverage        71.98%   71.97%   -0.01%     
===============================================
  Files               18       18              
  Lines             4230     4236       +6     
===============================================
+ Hits              3045     3049       +4     
- Misses            1185     1187       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@StevenLooman StevenLooman merged commit b73bbfa into StevenLooman:development Jan 24, 2025
10 of 12 checks passed
@StevenLooman
Copy link
Owner

Merged! Thank you for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants