Update sampling_stations data in package to include new NERR stations #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, @ballengerj. I'm going to review a few notes and make sure things check out, but I think this looks good. New package update should be pushed tomorrow. -Ben |
|
|
Hi @ballengerj, I'm going to reach out to the project manager on the NERRS team to make sure we have a solid maintenance plan before accepting this PR. However, I wanted to verify that you are currently able to complete the analysis you and Denise need from this branch. Is that correct? Thanks. |
|
Yes, I was able to complete the analysis Denise needed using the fork and updates I provided on my local machine. She unfortunately has been out of the office since I completed it, so I haven’t been able to verify whether she was able to complete it successfully.
Joey
Joseph C. Ballenger, PhD
Associate Marine Scientist
S. C. Department of Natural Resources
Marine Resources Research Institute
Phone: 843-953-9046
DNR Mobile: 843-901-2730
Email: ***@***.******@***.***>
From: Benjamin Crary ***@***.***>
Sent: Monday, November 21, 2022 12:16 PM
To: StormStories/SWMPrStorm ***@***.***>
Cc: Joseph Ballenger ***@***.***>; Mention ***@***.***>
Subject: Re: [StormStories/SWMPrStorm] Update sampling_stations data in package to include new NERR stations (PR #28)
Hi @ballengerj<https://github.com/ballengerj>, I'm going to reach out to the project manager on the NERRS team to make sure we have a solid maintenance plan before accepting this PR. However, I wanted to verify that you are currently able to complete the analysis you and Denise need from this branch.
Is that correct?
Thanks.
—
Reply to this email directly, view it on GitHub<#28 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACEBJPROQNRL76JR5LTNXBTWJOU3PANCNFSM6AAAAAASDR6PHY>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
EXTERNAL EMAIL: Do not click any links or open any attachments unless you trust the sender and know the content is safe.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Denise Sanger and Saundra Upchurch were having difficulties using the SWMPr_Storm_Story_Template to create a Hurricane Ian storm story for the ACE Basin Ft. Johnson site (acefjwq). They asked me to look at the code and I found that you had built-in a r data set with the SWMPrStorm package you use for the development of the stories. This dataset did not include nearly 30 NERR stations, including the ACE Basin Ft. Johnson site (acefjwq). Thus, I pulled from the CDMO site and updated the sampling_stations.rda file to include these "new" stations.