Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking] Fix upcoming state for videos #101

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Conversation

tymmesyde
Copy link
Member

@tymmesyde tymmesyde commented Mar 5, 2024

Was using the released date from the meta item instead of the video one, making it always false
Breaking change: rename upcomming to upcoming

@tymmesyde tymmesyde requested a review from elpiel March 5, 2024 17:35
@elpiel elpiel changed the title Fix upcoming state for videos [Breaking] Fix upcoming state for videos Mar 8, 2024
Copy link
Member

@elpiel elpiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tymmesyde could we make sure to update stremio-web accordingly as well so we don't forget (if we use it).
Also reference this PR so that we can track the progress of the change.

Thanks!

@tymmesyde
Copy link
Member Author

It's already using upcoming in the web app
But otherwise we need to always check for breaking changes before updating the core in any apps, by checking the changelog and the version

@tymmesyde tymmesyde merged commit dae0b0c into development Mar 12, 2024
1 check passed
@elpiel elpiel deleted the fix/video-upcoming branch March 22, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants