Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cleaned up whitespace processing and added whitespace tests #1267

Merged
merged 3 commits into from
May 16, 2023

Conversation

Sub6Resources
Copy link
Owner

Fixes #1146 and fixes #1251

@Sub6Resources Sub6Resources changed the title fix: Cleans up whitespace processing and adds whitespace tests fix: Cleaned up whitespace processing and added whitespace tests May 16, 2023
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch coverage: 87.27% and project coverage change: +0.42 🎉

Comparison is base (fe896de) 59.31% compared to head (46fb455) 59.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1267      +/-   ##
==========================================
+ Coverage   59.31%   59.73%   +0.42%     
==========================================
  Files          37       37              
  Lines        2652     2690      +38     
==========================================
+ Hits         1573     1607      +34     
- Misses       1079     1083       +4     
Impacted Files Coverage Δ
lib/src/builtins/styled_element_builtin.dart 92.51% <37.50%> (-4.30%) ⬇️
lib/src/processing/whitespace.dart 85.47% <95.12%> (+0.58%) ⬆️
lib/src/builtins/text_builtin.dart 96.15% <100.00%> (+0.32%) ⬆️
lib/src/tree/replaced_element.dart 63.15% <100.00%> (+4.33%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Sub6Resources Sub6Resources merged commit cc00406 into master May 16, 2023
@Sub6Resources Sub6Resources deleted the fix/whitespace-br branch May 16, 2023 14:51
Luca-CZ added a commit to CZ-App/flutter_html_lite that referenced this pull request Nov 11, 2024
…rsion

 - **FIX**: start list items on a new line ([Sub6Resources#1281](Sub6Resources#1281)). ([496d1aa](Sub6Resources@496d1aa))
 - **FIX**: Add "display: Display.block" to table ([Sub6Resources#1278](Sub6Resources#1278)). ([6350f02](Sub6Resources@6350f02))
 - **FIX**: improve API for ExtensionContext and export marker.dart ([Sub6Resources#1273](Sub6Resources#1273)). ([27e33a9](Sub6Resources@27e33a9))
 - **FIX**: Cleaned up whitespace processing and added whitespace tests ([Sub6Resources#1267](Sub6Resources#1267)). ([cc00406](Sub6Resources@cc00406))
 - **FIX**: a tag should not style as link if href is not provided ([Sub6Resources#1265](Sub6Resources#1265)). ([d7247cb](Sub6Resources@d7247cb))
 - **FEAT**: Update CssBoxWidget to handle rtl marker boxes ([Sub6Resources#1270](Sub6Resources#1270)). ([d709199](Sub6Resources@d709199))
 - **FEAT**: support vertical-align in inline styles ([Sub6Resources#1266](Sub6Resources#1266)). ([fe896de](Sub6Resources@fe896de))
 - **FEAT**: Add WrapperExtension helper ([Sub6Resources#1264](Sub6Resources#1264)). ([2ffa1dd](Sub6Resources@2ffa1dd))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant