Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exports is not defined #17

Closed
imlonghao opened this issue Dec 20, 2018 · 2 comments
Closed

exports is not defined #17

imlonghao opened this issue Dec 20, 2018 · 2 comments

Comments

@imlonghao
Copy link

imlonghao commented Dec 20, 2018 •
edited
Loading

在 #15 之后的版本浏览器控制台会报错：

Uncaught ReferenceError: exports is not defined
    at disqus.js:6

https://suka.js.org/DisqusJS/ Firefox / Chrome 能复现这个问题
@SukkaW
Copy link
Owner

SukkaW commented Dec 20, 2018 •
edited
Loading

#13
I think now I have to maintain 2 versions, one for module bundler and one for browser,

@SukkaW SukkaW mentioned this issue Jan 5, 2019
Merged
@SukkaW SukkaW closed this as completed in #18 Jan 5, 2019
@SukkaW
Copy link
Owner

SukkaW commented Jan 5, 2019

From 1.1.0, DisqusJS will functionally support AMD & CMD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@imlonghao @SukkaW