Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add export default DisqusJS #15

Merged
merged 1 commit into from
Nov 19, 2018
Merged

feat: add export default DisqusJS #15

merged 1 commit into from
Nov 19, 2018

Conversation

luyilin
Copy link

@luyilin luyilin commented Nov 19, 2018 •
edited
Loading

try to fix #13

@SukkaW
Copy link
Owner

SukkaW commented Nov 19, 2018

Are you sure it will works for your project? I mean, have you tried the modified version of DisqusJS in your project?

@luyilin
Copy link
Author

luyilin commented Nov 19, 2018

I updated DisqusJS to version 1.0.8 just now, but it is still {} when import it.
I use the rebuilt file in my project and it works well. Here is the example 😂https://minemine.cc/comment/

@SukkaW SukkaW merged commit 4b3af81 into SukkaW:master Nov 19, 2018
@luyilin luyilin deleted the add-export branch December 17, 2018 12:32
@imlonghao imlonghao mentioned this pull request Dec 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DisqusJS is {} when I import it
2 participants
@luyilin @SukkaW