allow overriding the init subsystem. #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relates to #141 We now allow using `node['sumologic']['init_style']` with any valid chef provider. Default is `nil` and will defer to ohai unless overridden. Note: it does not attempt an validation that you chose a valid provider. Signed-off-by: Ben Abrams <[email protected]>
|
@dannenberg sorry this completely fell off my radar I believe this should "solve" your problems, let me know if this does not work for you. |
|
@majormoses appears to do the trick. thank you! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #141
We now allow using
node['sumologic']['init_style']with any valid chef provider. Default isniland will defer to ohai unless overridden.Note: it does not attempt an validation that you chose a valid provider.
Signed-off-by: Ben Abrams [email protected]
General
Remove any versioning you did yourself if applicable
Update Changelog following the conventions laid out on Keep A Changelog with all new changes under
## [Unreleased]and using a### Added, Fixed, Changed, or Breaking Changesub-header.Update README with any necessary changes
RuboCop passes
Foodcritic passes
Existing tests pass
Purpose
Allow overwriting the init subsystem used when starting the collector.
Known Compatibility Issues
If you choose an init subsystem that the collector does not support you will need to write your init script yourself. There are a limited number of providers, at the time of writing this: https://github.com/chef/chef/tree/v13.4.19/lib/chef/provider/service is a list of them.