Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add script for components images update #115

Merged
merged 2 commits into from
Jun 19, 2024
Merged

feat: add script for components images update #115

merged 2 commits into from
Jun 19, 2024

Conversation

kasia-kujawa
Copy link
Contributor

@kasia-kujawa kasia-kujawa commented Jun 17, 2024 •
edited
Loading

example usage:

make update-components-images IMAGES_FILE=/operator/scripts/images.txt

example images.txt:

./scripts/get_images_sha256.sh
registry.connect.redhat.com/sumologic/fluent-bit:3.0.6-ubi
MISSING
registry.connect.redhat.com/sumologic/autoinstrumentation-dotnet:0.7.0-ubi
MISSING
registry.connect.redhat.com/sumologic/autoinstrumentation-java:1.26.0-ubi
MISSING
registry.connect.redhat.com/sumologic/autoinstrumentation-nodejs:0.40.0-ubi
MISSING
registry.connect.redhat.com/sumologic/autoinstrumentation-python:0.39b0-ubi
MISSING
registry.connect.redhat.com/sumologic/busybox:1.36.0-ubi
MISSING
registry.connect.redhat.com/sumologic/busybox:latest-ubi
MISSING
registry.connect.redhat.com/sumologic/kube-rbac-proxy:v0.11.0-ubi
MISSING
registry.connect.redhat.com/sumologic/kube-rbac-proxy:v0.15.0-ubi
registry.connect.redhat.com/sumologic/kube-rbac-proxy:@sha256:1153a4592746b05e019bde4d818d176ff9350c013f84d49829032540de882841
registry.connect.redhat.com/sumologic/kube-state-metrics:v2.7.0-ubi
MISSING
registry.connect.redhat.com/sumologic/metrics-server:0.7.0-debian-12-r8-ubi
MISSING
registry.connect.redhat.com/sumologic/nginx-unprivileged:1.26.0-alpine-sumo-0-ubi
MISSING
registry.connect.redhat.com/sumologic/node-exporter:v1.3.1-ubi
registry.connect.redhat.com/sumologic/node-exporter:@sha256:7acec4473ddf508514dca1d08335cfd071e345d7eca660793d59e09ef9f0491f
registry.connect.redhat.com/sumologic/opentelemetry-operator:0.95.0-ubi
MISSING
registry.connect.redhat.com/sumologic/prometheus-config-reloader:v0.59.2-ubi
MISSING
registry.connect.redhat.com/sumologic/prometheus-operator:v0.59.2-ubi
MISSING
registry.connect.redhat.com/sumologic/prometheus:v2.39.0-ubi
MISSING
registry.connect.redhat.com/sumologic/telegraf-operator:v1.3.11-ubi
MISSING
registry.connect.redhat.com/sumologic/telegraf:1.21.2-ubi
registry.connect.redhat.com/sumologic/telegraf:@sha256:ca396dad12a289aea9136da713020d31b179e9f49aae61c48332d61086d1d059
registry.connect.redhat.com/sumologic/thanos:v0.28.0-ubi
MISSING

Documentation will be added in next pull request.

@kasia-kujawa kasia-kujawa force-pushed the add-script-image-upadate branch 10 times, most recently from dcabe84 to b5bcacd Compare June 18, 2024 13:53
@kasia-kujawa kasia-kujawa changed the title feat: add script for components image update feat: add script for components images update Jun 18, 2024
@kasia-kujawa kasia-kujawa marked this pull request as ready for review June 18, 2024 13:54
@kasia-kujawa kasia-kujawa requested a review from a team as a code owner June 18, 2024 13:54
@kasia-kujawa kasia-kujawa force-pushed the add-script-image-upadate branch 3 times, most recently from 7227571 to 4b3d8e5 Compare June 18, 2024 14:04
@sumo-drosiek
Copy link
Contributor

Could you add some comments to the function? It will help with maintaining in the future

@kasia-kujawa kasia-kujawa force-pushed the add-script-image-upadate branch from 4b3d8e5 to a54de60 Compare June 19, 2024 09:00
@kasia-kujawa kasia-kujawa force-pushed the add-script-image-upadate branch from a54de60 to 4ffcde2 Compare June 19, 2024 09:08
@kasia-kujawa kasia-kujawa force-pushed the add-script-image-upadate branch from 4ffcde2 to e20ae1c Compare June 19, 2024 09:11
@kasia-kujawa kasia-kujawa force-pushed the add-script-image-upadate branch from e20ae1c to 630106c Compare June 19, 2024 09:20
sumo-drosiek
sumo-drosiek approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last suggestion and LGTM

@kasia-kujawa @sumo-drosiek
Update scripts/update_images.py
e8ffb49 
Co-authored-by: Dominik Rosiek <[email protected]>
@kasia-kujawa kasia-kujawa merged commit 4e7df07 into main Jun 19, 2024
3 checks passed
@kasia-kujawa kasia-kujawa deleted the add-script-image-upadate branch June 19, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumo-drosiek sumo-drosiek sumo-drosiek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kasia-kujawa @sumo-drosiek