Skip to content

Commit

Permalink
Add otel collector labels to metrics collection
Browse files Browse the repository at this point in the history
  • Loading branch information
rnishtala-sumo committed Aug 20, 2024
1 parent 12584bd commit bb8a839
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions tests/integration/features.go
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,6 @@ func GetMetricsFeature(expectedMetrics []string, metricsCollector MetricsCollect
expectedLabels = addCollectorSpecificMetricLabels(expectedLabels, releaseName, namespace, metricsCollector)
// drop some unnecessary labels
delete(expectedLabels, "prometheus_service")

return stepfuncs.WaitUntilExpectedMetricLabelsPresent(metricFilters, expectedLabels, waitDuration, tickDuration)(ctx, t, envConf)
},
).
Expand Down Expand Up @@ -245,7 +244,10 @@ func addCollectorSpecificMetricLabels(labels sumologicmock.Labels, releaseName s
"prometheus_service": fmt.Sprintf("%s-.*-kubelet", releaseName),
}
otelcolLabels := sumologicmock.Labels{
"_collector": "kubernetes",
"_collector": "kubernetes",
"server.address": ".*",
"server.port": ".*",
"url.scheme": ".*",
}

if collector == Prometheus {
Expand Down

0 comments on commit bb8a839

Please sign in to comment.