-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add option to disable service
enrichment
#1936
feat: add option to disable service
enrichment
#1936
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog 🤡
@@ -220,7 +220,7 @@ sumologic: | |||
fluentd: | |||
image: | |||
repository: public.ecr.aws/sumologic/kubernetes-fluentd | |||
tag: 1.12.2-sumo-10 | |||
tag: 1.12.2-sumo-11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was caught by the integration test https://github.com/SumoLogic/sumologic-kubernetes-collection/runs/4431276057?check_suite_focus=true#step:6:334
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe they just build longer than they used to - so while it's 🎉 that it was caught - there is no real error, we just need for images to be published (which is happening, just slow).
Ref https://github.com/SumoLogic/sumologic-kubernetes-fluentd/actions/runs/1544893588
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't matter if it's fast or slow. At the moment you merge this PR this image has to be available. No tricks, no postponing, no rushing things. When it's available then we can merge it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's something to shorten the Fluentd release time: SumoLogic/sumologic-kubernetes-fluentd#371
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I doubt publishing changes will make a difference. Most of the time is spent building the image for ARM, which tends to be very slow in QEMU. If we want it to be faster, we can add a build cache and/or try not to build native extensions during the image build process, which is what takes the lion's share of the time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a recent blog from Docker on this very topic https://www.docker.com/blog/faster-multi-platform-builds-dockerfile-cross-compilation-guide/, but I'm afraid it might not apply for our Ruby image build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, cross-compiling ruby extensions is probably not the easiest way of improving this process. I bet we could get quite far by configuring caching correctly for buildx, which isn't very difficult, but ECR doesn't support it yet.
9b0ec72
to
9e94f3d
Compare
No description provided.