-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: upgrade opentelemetry-operator Chart to 0.56.1 #3777
Conversation
12a9ccb
to
04dfcc3
Compare
04dfcc3
to
d4f376d
Compare
@@ -2464,8 +2464,7 @@ opentelemetry-operator: | |||
|
|||
## Specific for OpenTelemetry Operator chart values | |||
admissionWebhooks: | |||
failurePolicy: Fail | |||
enabled: true | |||
create: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this change affect helm chart upgrades in anyway? What changes would we need in the helm chart after this version of the operator?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so. If someone disabled webhooks, they'll get an error and will need to set create: false
instead of create: true
. The other values I removed because we were using defaults anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes to CRD handling that will require changes on our end as well.
ok, what about the upcoming changes mentioned here. Is there a breaking change in the operator that we should be tracking to upgrade to the next version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Operator Helm Chart v0.57.0 moves CRDs to templates. This effectively makes it impossible for us to use them, as we need to create an OpenTelemetryCollector CR during installation. We should move this discussion to an issue if you want to go into details, as it's not really related to this PR.
This is the last version before changes to CRD handling that will require changes on our end as well.
Checklist