fix(sumologicexporter): translate Telegraf metrics with OTLP format

This change fixes a regression introduced in #536
that caused the metric name translations
(the feature under the `translate_telegraf_attributes` setting)
to not work when using the OTLP format.
This change refactors the code so that all modifications to metrics
(attribute translation, metrics translation, dropping routing attribute)
are done before branching the code into different sending formats.

pkg/exporter/sumologicexporter/exporter.go

@@ -283,19 +283,6 @@ func (se *sumologicexporter) pushMetricsData(ctx context.Context, md pmetric.Met
 		tracesUrl,
 	)
 
-	// Follow different execution path for OTLP format
-	if sdr.config.MetricFormat == OTLPMetricFormat {
-		if err := sdr.sendOTLPMetrics(ctx, md); err != nil {
-			se.handleUnauthorizedErrors(ctx, err)
-			return consumererror.NewMetrics(err, md)
-		}
-		return nil
-	}
-
-	var (
-		errs []error
-	)
-
 	// Transform metrics metadata
 	// this includes dropping the routing attribute and translating attributes
 	rms := md.ResourceMetrics()
@@ -321,7 +308,16 @@ func (se *sumologicexporter) pushMetricsData(ctx context.Context, md pmetric.Met
 		}
 	}
 
-	droppedMetrics, errs := sdr.sendNonOTLPMetrics(ctx, md)
+	var droppedMetrics pmetric.Metrics
+	var errs []error
+	if sdr.config.MetricFormat == OTLPMetricFormat {
+		if err := sdr.sendOTLPMetrics(ctx, md); err != nil {
+			droppedMetrics = md
+			errs = []error{err}
+		}
+	} else {
+		droppedMetrics, errs = sdr.sendNonOTLPMetrics(ctx, md)
+	}
 
 	if len(errs) > 0 {
 		se.handleUnauthorizedErrors(ctx, errs...)

pkg/exporter/sumologicexporter/sender.go

@@ -596,11 +596,6 @@ func (s *sender) sendOTLPMetrics(ctx context.Context, md pmetric.Metrics) error
 	for i := 0; i < rms.Len(); i++ {
 		rm := rms.At(i)
 
-		if s.config.TranslateAttributes {
-			translateAttributes(rm.Resource().Attributes()).
-				CopyTo(rm.Resource().Attributes())
-		}
-
 		s.addSourceResourceAttributes(rm.Resource().Attributes())
 	}