fix(cascadingfilterprocessor): do not attach sampling.rule attribute if trace accept rules are not specified #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Do not attach sampling.rule attribute if trace accept rules are not specified
pmm-sumo
force-pushed
the
processor/cascading/apply-filter-on-accept-rule-only
branch
from
234ea94 to
87c5a1c
Compare
andrzej-stencel
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that
sampling.ruleattr is attached only when trace accept filters are defined only.Previously, when drop trace filters were specified the
sampling.rule=filteredattribute was attached, which in lack of probabilistic filter caused Trace2Metrics calculations create no actual metrics