fix(k8sprocessor)!: deprecate clusterName setting #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
3 tasks
swiatekm
force-pushed
the
fix/k8stagger/clustername
branch
from
504cfd6 to
ea2931c
Compare
kasia-kujawa
approved these changes
May 18, 2022
The respective ObjectMeta field is being removed from Kubernetes. It's practically never set and only confuses users.
swiatekm
force-pushed
the
fix/k8stagger/clustername
branch
from
ea2931c to
d543db3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The respective ObjectMeta field is being removed from Kubernetes. It's practically never set and only confuses users. It was also removed from the upstream processors: open-telemetry/opentelemetry-collector-contrib#9886.
This is technically a breaking change, but users shouldn't see any difference in practice.