Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): add pipelines to test and build on Go+BoringCrypto #588

Merged
merged 4 commits into from
Jun 28, 2022
Merged

chore(ci): add pipelines to test and build on Go+BoringCrypto #588

merged 4 commits into from
Jun 28, 2022

Conversation

kasia-kujawa
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the github_actions Pull requests that update Github_actions code label May 20, 2022
@kasia-kujawa kasia-kujawa force-pushed the kk-go+boring-ci-pipeline branch 15 times, most recently from aef36d1 to e264f23 Compare May 27, 2022 07:13
@kasia-kujawa kasia-kujawa force-pushed the kk-go+boring-ci-pipeline branch 14 times, most recently from de59f0a to 3257609 Compare May 27, 2022 11:58
@kasia-kujawa kasia-kujawa force-pushed the kk-go+boring-ci-pipeline branch 3 times, most recently from c56670b to 29fe8a0 Compare May 27, 2022 12:44
@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 27, 2022
@kasia-kujawa kasia-kujawa force-pushed the kk-go+boring-ci-pipeline branch from 29fe8a0 to 7573d15 Compare May 27, 2022 12:46
@kasia-kujawa kasia-kujawa force-pushed the kk-go+boring-ci-pipeline branch from 7573d15 to c0a4bb2 Compare June 8, 2022 15:01
@kasia-kujawa kasia-kujawa marked this pull request as ready for review June 9, 2022 06:20
@kasia-kujawa kasia-kujawa requested a review from a team as a code owner June 9, 2022 06:20
@sumo-drosiek
Copy link
Contributor

Is it possible to build the FIPS complianat image locally? I think we should have separate Dockerfile or ci possibility to do that

@kasia-kujawa kasia-kujawa force-pushed the kk-go+boring-ci-pipeline branch from c0a4bb2 to 89078f1 Compare June 9, 2022 07:13
@kasia-kujawa
Copy link
Contributor Author

Is it possible to build the FIPS complianat image locally? I think we should have separate Dockerfile or ci possibility to do that

In our CI binaries are built outside of the image and copied to the image but now I've noticed that in dev pipeline container image bases on go image so it would be good to have appropriate version of go in the containers for fips binaries.

Yes, we need to have Dockerfile to build container image locally for FIPS binaries, similar to this one.

so there are two things to do :)

@kasia-kujawa
Copy link
Contributor Author

In our CI binaries are built outside of the image and copied to the image but now I've noticed that in dev pipeline container image bases on go image so it would be good to have appropriate version of go in the containers for fips binaries.

Yes, we need to have Dockerfile to build container image locally for FIPS binaries, similar to this one.

so there are two things to do :)

This will be done in another PR.

@kasia-kujawa kasia-kujawa force-pushed the kk-go+boring-ci-pipeline branch 5 times, most recently from 24025e1 to daa3cf5 Compare June 13, 2022 11:58
sumo-drosiek
sumo-drosiek previously approved these changes Jun 14, 2022
View reviewed changes
@sumo-drosiek
Copy link
Contributor

I see that otelcol-sumo-darwin_arm64 do not have fips version

@sumo-drosiek sumo-drosiek dismissed their stale review June 14, 2022 06:48

missing arm64 darwin fips version

@kasia-kujawa kasia-kujawa force-pushed the kk-go+boring-ci-pipeline branch from daa3cf5 to 52eca02 Compare June 28, 2022 08:15
@kasia-kujawa kasia-kujawa force-pushed the kk-go+boring-ci-pipeline branch from 3a48421 to 6b35530 Compare June 28, 2022 12:51
@kasia-kujawa
Copy link
Contributor Author

@sumo-drosiek please take another look

sumo-drosiek
sumo-drosiek approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine 🎸

@kasia-kujawa kasia-kujawa merged commit 69b6926 into main Jun 28, 2022
@kasia-kujawa kasia-kujawa deleted the kk-go+boring-ci-pipeline branch June 28, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumo-drosiek sumo-drosiek sumo-drosiek approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation github_actions Pull requests that update Github_actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kasia-kujawa @sumo-drosiek