Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CumulativeToDelta Processor #597

Merged

Conversation

EddieEldridge
Copy link
Contributor

@EddieEldridge EddieEldridge commented Jun 1, 2022

@sumo-drosiek
Copy link
Contributor

sumo-drosiek commented Jun 1, 2022

It should be rather added here (bottom part of snippet):

processors:
# Processors with non-upstreamed changes:
- gomod: "github.com/SumoLogic/sumologic-otel-collector/pkg/processor/cascadingfilterprocessor v0.0.0-00010101000000-000000000000"
path: ./../pkg/processor/cascadingfilterprocessor
- gomod: "github.com/open-telemetry/opentelemetry-collector-contrib/processor/k8sprocessor v0.0.0-00010101000000-000000000000"
path: ./../pkg/processor/k8sprocessor
- gomod: "github.com/SumoLogic/sumologic-otel-collector/pkg/processor/sourceprocessor v0.0.0-00010101000000-000000000000"
path: ./../pkg/processor/sourceprocessor
- gomod: "github.com/SumoLogic/sumologic-otel-collector/pkg/processor/sumologicschemaprocessor v0.0.0-00010101000000-000000000000"
path: ./../pkg/processor/sumologicschemaprocessor
- gomod: "github.com/SumoLogic/sumologic-otel-collector/pkg/processor/sumologicsyslogprocessor v0.0.0-00010101000000-000000000000"
path: ./../pkg/processor/sumologicsyslogprocessor
- gomod: "github.com/SumoLogic/sumologic-otel-collector/pkg/processor/metricfrequencyprocessor v0.0.0-00010101000000-000000000000"
path: ./../pkg/processor/metricfrequencyprocessor
# Upstream processors:
# Since include-code was removed we need to manually add all core components that we want to include:
# https://github.com/open-telemetry/opentelemetry-collector/pull/4616
- import: go.opentelemetry.io/collector/processor/batchprocessor
gomod: go.opentelemetry.io/collector v0.51.0
- import: go.opentelemetry.io/collector/processor/memorylimiterprocessor
gomod: go.opentelemetry.io/collector v0.51.0
- gomod: "github.com/open-telemetry/opentelemetry-collector-contrib/processor/attributesprocessor v0.51.0"
- gomod: "github.com/open-telemetry/opentelemetry-collector-contrib/processor/filterprocessor v0.51.0"
- gomod: "github.com/open-telemetry/opentelemetry-collector-contrib/processor/groupbyattrsprocessor v0.51.0"
- gomod: "github.com/open-telemetry/opentelemetry-collector-contrib/processor/groupbytraceprocessor v0.51.0"
- gomod: "github.com/open-telemetry/opentelemetry-collector-contrib/processor/metricstransformprocessor v0.51.0"
- gomod: "github.com/open-telemetry/opentelemetry-collector-contrib/processor/probabilisticsamplerprocessor v0.51.0"
- gomod: "github.com/open-telemetry/opentelemetry-collector-contrib/processor/resourcedetectionprocessor v0.51.0"
- gomod: "github.com/open-telemetry/opentelemetry-collector-contrib/processor/resourceprocessor v0.51.0"
- gomod: "github.com/open-telemetry/opentelemetry-collector-contrib/processor/routingprocessor v0.51.0"
- gomod: "github.com/open-telemetry/opentelemetry-collector-contrib/processor/spanmetricsprocessor v0.51.0"
- gomod: "github.com/open-telemetry/opentelemetry-collector-contrib/processor/spanprocessor v0.51.0"
- gomod: "github.com/open-telemetry/opentelemetry-collector-contrib/processor/tailsamplingprocessor v0.51.0"

as path: ./../pkg/processor/cumulativetodeltaprocessor refers to this repository code

@sumo-drosiek
Copy link
Contributor

@EddieEldridge thank you for the contribution :)

@EddieEldridge
Copy link
Contributor Author

It should be rather added here (bottom part of snippet):

processors:
# Processors with non-upstreamed changes:
- gomod: "github.com/SumoLogic/sumologic-otel-collector/pkg/processor/cascadingfilterprocessor v0.0.0-00010101000000-000000000000"
path: ./../pkg/processor/cascadingfilterprocessor
- gomod: "github.com/open-telemetry/opentelemetry-collector-contrib/processor/k8sprocessor v0.0.0-00010101000000-000000000000"
path: ./../pkg/processor/k8sprocessor
- gomod: "github.com/SumoLogic/sumologic-otel-collector/pkg/processor/sourceprocessor v0.0.0-00010101000000-000000000000"
path: ./../pkg/processor/sourceprocessor
- gomod: "github.com/SumoLogic/sumologic-otel-collector/pkg/processor/sumologicschemaprocessor v0.0.0-00010101000000-000000000000"
path: ./../pkg/processor/sumologicschemaprocessor
- gomod: "github.com/SumoLogic/sumologic-otel-collector/pkg/processor/sumologicsyslogprocessor v0.0.0-00010101000000-000000000000"
path: ./../pkg/processor/sumologicsyslogprocessor
- gomod: "github.com/SumoLogic/sumologic-otel-collector/pkg/processor/metricfrequencyprocessor v0.0.0-00010101000000-000000000000"
path: ./../pkg/processor/metricfrequencyprocessor
# Upstream processors:
# Since include-code was removed we need to manually add all core components that we want to include:
# https://github.com/open-telemetry/opentelemetry-collector/pull/4616
- import: go.opentelemetry.io/collector/processor/batchprocessor
gomod: go.opentelemetry.io/collector v0.51.0
- import: go.opentelemetry.io/collector/processor/memorylimiterprocessor
gomod: go.opentelemetry.io/collector v0.51.0
- gomod: "github.com/open-telemetry/opentelemetry-collector-contrib/processor/attributesprocessor v0.51.0"
- gomod: "github.com/open-telemetry/opentelemetry-collector-contrib/processor/filterprocessor v0.51.0"
- gomod: "github.com/open-telemetry/opentelemetry-collector-contrib/processor/groupbyattrsprocessor v0.51.0"
- gomod: "github.com/open-telemetry/opentelemetry-collector-contrib/processor/groupbytraceprocessor v0.51.0"
- gomod: "github.com/open-telemetry/opentelemetry-collector-contrib/processor/metricstransformprocessor v0.51.0"
- gomod: "github.com/open-telemetry/opentelemetry-collector-contrib/processor/probabilisticsamplerprocessor v0.51.0"
- gomod: "github.com/open-telemetry/opentelemetry-collector-contrib/processor/resourcedetectionprocessor v0.51.0"
- gomod: "github.com/open-telemetry/opentelemetry-collector-contrib/processor/resourceprocessor v0.51.0"
- gomod: "github.com/open-telemetry/opentelemetry-collector-contrib/processor/routingprocessor v0.51.0"
- gomod: "github.com/open-telemetry/opentelemetry-collector-contrib/processor/spanmetricsprocessor v0.51.0"
- gomod: "github.com/open-telemetry/opentelemetry-collector-contrib/processor/spanprocessor v0.51.0"
- gomod: "github.com/open-telemetry/opentelemetry-collector-contrib/processor/tailsamplingprocessor v0.51.0"

as path: ./../pkg/processor/cumulativetodeltaprocessor refers to this repository code

Woops, my bad. Should be fixed now :)

@sumo-drosiek
Copy link
Contributor

Woops, my bad. Should be fixed now :)

We would like to to keep alphabetical order there 😅

@sumo-drosiek
Copy link
Contributor

And please update changelog 🙏

@sumo-drosiek
Copy link
Contributor

and readme

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 1, 2022
@sumo-drosiek
Copy link
Contributor

sumo-drosiek commented Jun 2, 2022

@EddieEldridge Crucial part of readme is the table with list of supported components. Unfortunately this is alphabetical as well 😓

I'm personally using this plugin to format table: https://marketplace.visualstudio.com/items?itemName=darkriszty.markdown-table-prettify

@EddieEldridge
Copy link
Contributor Author

@EddieEldridge Crucial part of readme is the table with list of supported components. Unfortunately this is alphabetical as well 😓

I'm personally using this plugin to format table: https://marketplace.visualstudio.com/items?itemName=darkriszty.markdown-table-prettify

Ok, after much struggle I think I've managed to add that in without messing up the whole table. Thanks for being patient :D

README.md Outdated Show resolved Hide resolved
@swiatekm
Copy link

swiatekm commented Jun 2, 2022

@EddieEldridge I think we're good to go after you rebase and resolve conflicts. It'd be best if you squashed it all to a single commit and followed https://www.conventionalcommits.org/en/v1.0.0/ for the message.

@EddieEldridge EddieEldridge force-pushed the add-cumulative-to-delta-processor branch from 98d01c4 to 8214add Compare June 3, 2022 09:21
@EddieEldridge EddieEldridge force-pushed the add-cumulative-to-delta-processor branch from f06d8ed to 1b5c978 Compare June 3, 2022 09:55
@EddieEldridge
Copy link
Contributor Author

EddieEldridge commented Jun 3, 2022

Cool, I think that should be good now. Let me know if there's anything else that needs changing or if you have any nitpicks :)

@swiatekm swiatekm self-requested a review June 3, 2022 11:18
Copy link

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sumo-drosiek sumo-drosiek merged commit 3e7a698 into SumoLogic:main Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants