-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CumulativeToDelta Processor #597
Add CumulativeToDelta Processor #597
Conversation
It should be rather added here (bottom part of snippet): sumologic-otel-collector/otelcolbuilder/.otelcol-builder.yaml Lines 34 to 69 in 956e103
as |
@EddieEldridge thank you for the contribution :) |
Woops, my bad. Should be fixed now :) |
We would like to to keep alphabetical order there 😅 |
And please update changelog 🙏 |
and readme |
@EddieEldridge Crucial part of readme is the table with list of supported components. Unfortunately this is alphabetical as well 😓 I'm personally using this plugin to format table: https://marketplace.visualstudio.com/items?itemName=darkriszty.markdown-table-prettify |
Ok, after much struggle I think I've managed to add that in without messing up the whole table. Thanks for being patient :D |
@EddieEldridge I think we're good to go after you rebase and resolve conflicts. It'd be best if you squashed it all to a single commit and followed https://www.conventionalcommits.org/en/v1.0.0/ for the message. |
98d01c4
to
8214add
Compare
f06d8ed
to
1b5c978
Compare
Cool, I think that should be good now. Let me know if there's anything else that needs changing or if you have any nitpicks :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Addresses: Include cumulativetodeltaprocessor from contrib #595
Cumulative To Delta Processor
My use case of this is that not all vendors support Cumulative metrics and being able to use this processor to convert them to Delta would be incredibly helpful.