-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add missing core receivers, processors and extensions #614
Conversation
e388567
to
0749433
Compare
e18e696
to
1650cf1
Compare
0749433
to
ec4f0c4
Compare
Maybe add a bullet point to the OT core upgrade instructions about adding any new components? |
I will, I was thinking also about auotomating it, but as I use VSCode, LibreOffice, grep, copy and paste, this doesn't seem to be legit 😅 |
14b6096
to
c093a9e
Compare
docs/release.md
Outdated
@@ -144,6 +145,92 @@ make gotest | |||
|
|||
in the repository root. | |||
|
|||
## Add missing upstream components |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@swiatekm-sumo Please look at it 😨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think those are good instructions for when one wants to regenerate everything from scratch. Most of the time, though we just want to add components that were added since the previous release. And for that, it's sufficient to read the changelogs for core and contrib and then update builder config and the support table manually.
So I'd start the section with that, and include the rest as a "just in case".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated it. This is valid point about using changelogs of upstream projects 👍
Signed-off-by: Dominik Rosiek <[email protected]>
Signed-off-by: Dominik Rosiek <[email protected]>
03df405
to
5ea8a49
Compare
Signed-off-by: Dominik Rosiek <[email protected]>
Signed-off-by: Dominik Rosiek <[email protected]>
Signed-off-by: Dominik Rosiek <[email protected]>
d5622d0
to
ddfe604
Compare
Signed-off-by: Dominik Rosiek <[email protected]>
ddfe604
to
6454885
Compare
Signed-off-by: Dominik Rosiek [email protected]