Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing core receivers, processors and extensions #614

Merged
merged 8 commits into from
Jun 14, 2022

Conversation

sumo-drosiek
Copy link
Contributor

Signed-off-by: Dominik Rosiek [email protected]

@sumo-drosiek sumo-drosiek marked this pull request as ready for review June 13, 2022 13:44
@sumo-drosiek sumo-drosiek requested a review from a team as a code owner June 13, 2022 13:44
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 13, 2022
@sumo-drosiek sumo-drosiek force-pushed the drosiek-missing-components branch from e388567 to 0749433 Compare June 13, 2022 13:54
@sumo-drosiek sumo-drosiek force-pushed the drosiek-update-ot-core branch from e18e696 to 1650cf1 Compare June 13, 2022 13:57
@sumo-drosiek sumo-drosiek force-pushed the drosiek-missing-components branch from 0749433 to ec4f0c4 Compare June 13, 2022 14:00
@swiatekm
Copy link

Maybe add a bullet point to the OT core upgrade instructions about adding any new components?

@sumo-drosiek
Copy link
Contributor Author

I will, I was thinking also about auotomating it, but as I use VSCode, LibreOffice, grep, copy and paste, this doesn't seem to be legit 😅

@sumo-drosiek sumo-drosiek force-pushed the drosiek-missing-components branch from 14b6096 to c093a9e Compare June 14, 2022 06:17
docs/release.md Outdated
@@ -144,6 +145,92 @@ make gotest

in the repository root.

## Add missing upstream components
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swiatekm-sumo Please look at it 😨

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think those are good instructions for when one wants to regenerate everything from scratch. Most of the time, though we just want to add components that were added since the previous release. And for that, it's sufficient to read the changelogs for core and contrib and then update builder config and the support table manually.

So I'd start the section with that, and include the rest as a "just in case".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated it. This is valid point about using changelogs of upstream projects 👍

Dominik Rosiek added 2 commits June 14, 2022 09:56
Signed-off-by: Dominik Rosiek <[email protected]>
Signed-off-by: Dominik Rosiek <[email protected]>
@sumo-drosiek sumo-drosiek force-pushed the drosiek-update-ot-core branch from 03df405 to 5ea8a49 Compare June 14, 2022 07:57
@github-actions github-actions bot added the go label Jun 14, 2022
@sumo-drosiek sumo-drosiek force-pushed the drosiek-missing-components branch from d5622d0 to ddfe604 Compare June 14, 2022 11:31
@github-actions github-actions bot removed the go label Jun 14, 2022
@sumo-drosiek sumo-drosiek force-pushed the drosiek-missing-components branch from ddfe604 to 6454885 Compare June 14, 2022 11:34
Base automatically changed from drosiek-update-ot-core to main June 14, 2022 12:17
@sumo-drosiek sumo-drosiek enabled auto-merge (squash) June 14, 2022 12:24
@sumo-drosiek sumo-drosiek disabled auto-merge June 14, 2022 12:24
@sumo-drosiek sumo-drosiek enabled auto-merge (squash) June 14, 2022 12:31
@sumo-drosiek sumo-drosiek merged commit 9163c95 into main Jun 14, 2022
@sumo-drosiek sumo-drosiek deleted the drosiek-missing-components branch June 14, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants