fix(cascading_filter): fix leak on traces where decision was made #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I made some calculations and test should take about 20s, is it possible to reduce it somehow? |
So that's the bummer with it, the shortest interval for compaction to kick is 1s. With margin, this gets bigger. I'm thinking about either disabling the test or changing the internal API to accept shorter intervals |
|
We can add some comment to the test and if it will be too annoying we can fix it then. Of course you can fix it now as well :) |
pmm-sumo
force-pushed
the
cascading-filter-fix
branch
from
0db2eaf to
21390c9
Compare
github-actions
bot
added
the
documentation
|
@sumo-drosiek the fix won't be that simple so I skipped the test for now. I am keen to rework the underlying architecture of the cascading filter and then we could fix that as well |
pmm-sumo
force-pushed
the
cascading-filter-fix
branch
from
21390c9 to
417946f
Compare
pmm-sumo
force-pushed
the
cascading-filter-fix
branch
from
417946f to
a40a9ec
Compare
sumo-drosiek
approved these changes
Jun 14, 2022
This was referenced Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the case with increased memory consumption when spans for traces where decision was already made are observed