chore: upgrade OT core to v0.54.0 #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
andrzej-stencel
force-pushed
the
update-otc-v0.54.0
branch
from
00f3619 to
115e3f8
Compare
Comment on lines
+411
to
+412
| time.Sleep(10 * time.Millisecond) | ||
|
|
andrzej-stencel
force-pushed
the
update-otc-v0.54.0
branch
from
291ddf3 to
bbef4db
Compare
Removing: - fluentbitextension - prometheusexecreceiver
andrzej-stencel
force-pushed
the
update-otc-v0.54.0
branch
from
bbef4db to
25794df
Compare
Added the `time.Sleep()` call to make sure the second event is actually always sent as the second one.
andrzej-stencel
force-pushed
the
update-otc-v0.54.0
branch
from
25794df to
6e0ad5e
Compare
sumo-drosiek
approved these changes
Jun 30, 2022
pdelewski
approved these changes
Jun 30, 2022
| @@ -408,6 +408,8 @@ func TestStorage(t *testing.T) { | |||
| host := storagetest.NewStorageHost(t, storageDir, "test") | |||
| assert.NoError(t, receiver.Start(ctx, host)) | |||
|
|
|||
| time.Sleep(10 * time.Millisecond) | |||
There was a problem hiding this comment.
What's the reason behind this?
There was a problem hiding this comment.
This is to ensure that the second event actually comes in after the first event.
| @@ -343,7 +343,7 @@ func TestNoStorage(t *testing.T) { | |||
| // Both events should be picked up by the receiver. | |||
| assert.Eventually(t, func() bool { | |||
| return assert.Equal(t, 2, logsSink.LogRecordCount()) | |||
| }, time.Second, 100*time.Millisecond) | |||
| }, 100*time.Millisecond, 10*time.Millisecond) | |||
There was a problem hiding this comment.
Why do we needed to use Millisecond here?
There was a problem hiding this comment.
We could use time.Second too, but I just wanted the test to be quicker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.