feat(cascadingfilter): refactor the code, better support of decision history #654
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces several new things
Decision history is now stored in LRU cache. This allows for better managing of long-running spans. Also, the decision history is no longer tied to batches and those can be released earlier. The param is controlled by
history_size
(by default equal tonum_traces
)Released traces now have info about which rule sampled them, if possible, e.g.
decision_wait
) can be now controlled viaprior_spans_rate
param (by default50%
ofspans_per_second
). The limit is not counted towardsspans_per_second
. Those are also marked as such (though no probability is calculated for them). E.g.