feat(sumologicexporter): do not send empty OTLP requests #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When en empty metrics or traces dataset is passed to the Sumo Logic exporter, an empty-bodied request is sent. This behavior is in fact in line with what the upstream OTLP HTTP exporter does for all signals - logs, metrics and traces.
For metrics and traces in OTLP format, if there is no data to be sent, do not send an empty request. This is a performance optimization to save on unneeded network calls. For logs, en empty request is not being sent, so there is no change needed.
github-actions
bot
added
the
documentation
swiatekm
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when en empty metrics or traces dataset is passed to the Sumo Logic exporter, an empty-bodied request is sent to the backend.
This behavior is in fact in line with what the upstream OTLP HTTP exporter does for all signals - logs, metrics and traces.
This change modifies this behavior for metrics and traces so that the empty request is not sent. This is to prevent an unnecessary network call.
For logs, the current behavior is to not send the empty request when an empty dataset is passed to the exporter, and there is no change to this behavior.