feat(sumologicexporter): do not retry on '400 Bad Request' response #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrzej-stencel
changed the title
If the server responds with '400 Bad Request', the exporter should not retry the request. This is in line what the upstream OTLP HTTP exporter does: https://github.com/open-telemetry/opentelemetry-collector/blob/v0.55.0/exporter/otlphttpexporter/otlp.go#L181-L184
andrzej-stencel
force-pushed
the
bad-request-permanent-error
branch
from
39cc6c9 to
58f2d60
Compare
github-actions
bot
added
the
documentation
swiatekm
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the server responds with '400 Bad Request', the exporter should not retry the request.
This is in line what the upstream OTLP HTTP exporter does:
https://github.com/open-telemetry/opentelemetry-collector/blob/v0.55.0/exporter/otlphttpexporter/otlp.go#L181-L184