fix(k8sprocessor): only apply the node filter to Pods #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiatekm
force-pushed
the
fix/k8sprocessor/nodefilter
branch
from
622bdec to
50ffef8
Compare
github-actions
bot
added
the
documentation
sumo-drosiek
approved these changes
Jul 14, 2022
mat-rumian
approved these changes
Jul 14, 2022
swiatekm
force-pushed
the
fix/k8sprocessor/nodefilter
branch
from
50ffef8 to
5d00144
Compare
I created a dev build for it here: https://github.com/SumoLogic/sumologic-otel-collector/actions/runs/2670446579 if you want to test before merging. |
swiatekm
force-pushed
the
fix/k8sprocessor/nodefilter
branch
from
5d00144 to
1223bd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Node filter should only be used for the Pod informer, as only Pods have the
spec.Nodefield. This fixes #651 @mat-rumian