chore(deps): bump golang from 1.18.4 to 1.19.2 #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
github-actions
bot
added
the
documentation
andrzej-stencel
suggested changes
Oct 5, 2022
|
Upstream currently uses 1.18 still, so no reason to upgrade right now. |
github-actions
bot
added
github_actions
andrzej-stencel
force-pushed
the
dependabot/docker/golang-1.19.2
branch
from
304023a to
f2657bc
Compare
I don't think that's the case, not sure where you got that? See here and other similar places. We decided with the team to use Go 1.19 even when the FIPS binary uses Go 1.18. |
andrzej-stencel
approved these changes
Oct 18, 2022
I think I must've been looking at the package minimum requirements instead of the CI. |
swiatekm
approved these changes
Oct 18, 2022
Bumps golang from 1.18.4 to 1.19.2. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Not updating the "go 1.18" in go.mod files until upstream does this. This is to make it possible to build other distributions with Go 1.18 that include Sumo components. For example, a customer of Sumo might want to build their own distro but they want to use Go 1.18.
andrzej-stencel
force-pushed
the
dependabot/docker/golang-1.19.2
branch
from
6fa2ca9 to
8da18d0
Compare
sumo-drosiek
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps golang from 1.18.4 to 1.19.2.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)