feat(receiver/apache)!: enable feature gates by default #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
swiatekm
reviewed
Nov 17, 2022
aboguszewski-sumo
force-pushed
the
enable-apache-resources-default
branch
2 times, most recently
from
88c38de to
ad4e49a
Compare
Comment on lines
+45
to
+48
| if err != nil { | ||
| return fmt.Errorf("setting feature gate flags failed: %s", err) | ||
| } | ||
|
|
There was a problem hiding this comment.
Is it okay to return an error here instead of continuing? Afaik there's no logger in this function, so log and continue wouldn't work.
There was a problem hiding this comment.
This will cause otel to terminate with this error, which I think is fine, as this can only error if we try to set flags which don't exist, afaik.
swiatekm
approved these changes
Nov 17, 2022
aboguszewski-sumo
force-pushed
the
enable-apache-resources-default
branch
from
ad4e49a to
04149ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.