feat(packaging/msi): add msi packaging #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Kolberg <[email protected]>
github-actions
bot
added
the
documentation
Signed-off-by: Justin Kolberg <[email protected]>
Signed-off-by: Justin Kolberg <[email protected]>
| @@ -19,6 +19,7 @@ This release introduces the following breaking changes: | |||
| - feat: add glob config provider [#713] | |||
| - feat(build): validate FIPS mode at build time and runtime [#693] | |||
| - feat(ci): add windows builds to dev & pr jobs [#762] | |||
| - feat(packaging/msi): add msi packaging [#852] | |||
There was a problem hiding this comment.
You probably need to add the definition of the link [#852] down below, like this:
[#852]: https://github.com/SumoLogic/sumologic-otel-collector/pull/852
CONTRIBUTING.md
Outdated
| 1. Install Visual Studio 2019 or newer with the `.NET desktop development` | ||
| workload selected in the installer. | ||
|
|
||
| 1. Open `cmd` and add msbuild to the user PATH. The path may differ depending on |
There was a problem hiding this comment.
Perhaps use the "Developer Command Prompt for VS 2019/2022" instead of using the regular "cmd" and adding MSBuild to path?
CONTRIBUTING.md
Outdated
| setx path "%PATH%;%ProgramFiles(x86)%\Microsoft Visual Studio\2019\Community\MSBuild\Current\Bin" | ||
| ``` | ||
|
|
||
| 1. Navigate to the `packaging/msi/wix` directory and run: |
There was a problem hiding this comment.
Perhaps worth mentioning that you need to msbuild -Restore /p:Platform=x64 before that, and that you need to have the otelcol binary built first for that to work. At least this was my experience.
There was a problem hiding this comment.
Good catch, those steps are indeed required.
andrzej-stencel
approved these changes
Nov 29, 2022
There was a problem hiding this comment.
I tried it on a fresh Windows virtual machine downloaded from here and it worked 🎉 🏆 👏
Signed-off-by: Justin Kolberg <[email protected]>
Signed-off-by: Justin Kolberg <[email protected]>
Signed-off-by: Justin Kolberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Justin Kolberg [email protected]
Adds code for building MSI packages with WiX and a C# DLL for manipulating YAML files when the MSI is executed. Only amd64 is tested and supported but it shouldn't be much work to add x86 and arm64 down the road.