Integrate collector with new metadata api #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
github-actions
bot
added
the
documentation
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
portertech
commented
Dec 14, 2022
portertech
commented
Dec 14, 2022
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
portertech
commented
Dec 28, 2022
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
…rk proxy info Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
sumo-drosiek
reviewed
Jan 5, 2023
Comment on lines
+1
to
+37
| // Copyright The OpenTelemetry Authors | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package api | ||
|
|
||
| type OpenMetadataHostDetails struct { | ||
| Name string `json:"name"` | ||
| OsName string `json:"osName"` | ||
| OsVersion string `json:"osVersion"` | ||
| Environment string `json:"environment"` | ||
| } | ||
|
|
||
| type OpenMetadataCollectorDetails struct { | ||
| RunningVersion string `json:"runningVersion"` | ||
| } | ||
|
|
||
| type OpenMetadataNetworkDetails struct { | ||
| HostIpAddress string `json:"hostIpAddress"` | ||
| } | ||
|
|
||
| type OpenMetadataRequestPayload struct { | ||
| HostDetails OpenMetadataHostDetails `json:"hostDetails"` | ||
| CollectorDetails OpenMetadataCollectorDetails `json:"collectorDetails"` | ||
| NetworkDetails OpenMetadataNetworkDetails `json:"networkDetails"` | ||
| TagDetails map[string]interface{} `json:"tagDetails"` | ||
| } |
There was a problem hiding this comment.
Are we going to change api in the futher? Do we need any kind of versioning?
There was a problem hiding this comment.
I don't believe so, there may be additional fields. I used registration for reference.
sumo-drosiek
reviewed
Jan 5, 2023
swiatekm
reviewed
Jan 5, 2023
|
|
||
| se.logger.Info("Updating collector metadata", | ||
| zap.String("URL", u.String()), | ||
| zap.String("body", buff.String())) |
There was a problem hiding this comment.
If we're going to log this, we should make sure that it's human-readable. Setting an indentation level on the encoder should suffice.
There was a problem hiding this comment.
Zap String() doesn't pretty print it as expected, for example: {\n\t\t\"runningVersion\":
There was a problem hiding this comment.
This logging is really for our own testing, it should moved to debug or be removed when we remove the feature gate.
Co-authored-by: Mikołaj Świątek <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
sumo-drosiek
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrated the collector with the new metadata API. Update the collector's metadata on every process start, before the heartbeat loop is initialized. Metadata is important to the user experience, errors result in retries with back-off.
Spec doc.
Jira ticket.
This feature uses a gate (for now), you must enable it via the CLI with the
--feature-gatesflag. For example: