-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpAMP Agent Extension #885
Conversation
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
This extension is currently able to authenticate to our OpAMP server and send a mock effective configuration on request. There is a known race condition in regards to authentication.
The OpAMP server does not yet reply with a remote configuration to apply. If it were to reply with one, the extension's OpAMP agent would produce a new effective configuration and report it to the server. The effective configuration is not yet applied to the collector itself (soon). This work is in a state where it is useful for testing the OpAMP server development. |
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
@sumo-drosiek I'll definitely call upon you for a review once things stabilize 👍 |
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@portertech one thing that I thing we need is a README, other than that LGTM (as alpha feature that's disabled by default 😉 )
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
@@ -0,0 +1,94 @@ | |||
# OpAMP Agent Extension |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@perk-sumo Is this sufficient? I used the Sumo extension readme as a base.
Creating this PR for increased visibility, early feedback, and OpAMP server testing. This pull-request supersedes #855.
This OpAMP agent implementation manages a single local configuration file (e.g.
opamp-remote-config.yaml
) intended to be consumed by the glob configuration provider. The configuration file directory is configurable viaremote_configuration_directory
, this directory must match the glob configuration provider pattern used by the collector (e.g.remote_configuration_directory: /etc/otelcol-sumo/conf.d
->--config "glob:/etc/otelcol-sumo/conf.d/*"
). Remote configuration updates trigger a collector reload via a SIGHUP signal (to self).Example OpAMP configuration for testing: