chore: update OT core to 0.69.0 #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
swiatekm
force-pushed
the
chore/upgrade-core
branch
3 times, most recently
from
ff8c5a1 to
7d5715e
Compare
swiatekm
force-pushed
the
chore/upgrade-core
branch
from
7d5715e to
ab401e4
Compare
aboguszewski-sumo
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure why
staticcheckdidn't find uses of deprecatedconfig.*Settingsfields.There's one other problem here. Some our components use a test package from upstream, and this test package has a dependency on the
zpagesextension, whose dependencies weren't upgraded in0.69.0core. I don't understand go packaging with multiple replaces that well, but the end result was that the tests wanted to use version0.68.0of that package, which isn't compatible with0.69.0. So I had to manually replace it in each component that uses it. Not sure if there's a more graceful way.