Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: FIPS support #902

Merged
merged 2 commits into from
Jan 25, 2023
Merged

docs: FIPS support #902

merged 2 commits into from
Jan 25, 2023

Conversation

swiatekm
Copy link

@swiatekm swiatekm commented Jan 23, 2023

Officially claim FIPS 140-3 support. Add a document explaining how the binaries can be obtained, and how to verify their correctness.

Delete remaining references to FIPS builds on darwin. BoringCrypto is only certified for Linux on amd64.

@swiatekm swiatekm requested a review from a team as a code owner January 23, 2023 11:16
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 23, 2023
docs/fips.md Outdated Show resolved Hide resolved
Copy link

@perk perk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for one comment.

Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link

@dochel dochel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments...

docs/fips.md Outdated Show resolved Hide resolved
docs/fips.md Show resolved Hide resolved
docs/fips.md Outdated Show resolved Hide resolved
docs/fips.md Outdated Show resolved Hide resolved
docs/fips.md Outdated Show resolved Hide resolved
Copy link

@dochel dochel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you! :)

@swiatekm swiatekm enabled auto-merge (rebase) January 25, 2023 09:40
Mikołaj Świątek added 2 commits January 25, 2023 12:45
BoringCrypto is only certified for Linux on amd64.
@swiatekm swiatekm merged commit 30a25de into main Jan 25, 2023
@swiatekm swiatekm deleted the docs/fips branch January 25, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants