feat(sumologicextension): use hostname as default collector name #918
Conversation
swiatekm
force-pushed
the
feat/sumologicextension/collector-guid
branch
from
2d69b2b to
fefd3d1
Compare
github-actions
bot
added
the
documentation
swiatekm
force-pushed
the
feat/sumologicextension/collector-guid
branch
from
fefd3d1 to
25c57d1
Compare
I think the default behaviour is better in this case. Clobber would actually delete the existing collector, which is a destructive action I'd rather not do without explicit user opt-in. Maybe we should log a warning in this case? |
swiatekm
force-pushed
the
feat/sumologicextension/collector-guid
branch
from
25c57d1 to
ec50e64
Compare
I added it. |
| if collectorName != resp.CollectorName { | ||
| se.logger.Warn("Collector name already in use, registered modified name", zap.String("registered_name", resp.CollectorName)) | ||
| } | ||
|
|
There was a problem hiding this comment.
Nice, but not sure if we should mention clobber or any documentation here
There was a problem hiding this comment.
Hm, I probably should add this behaviour to the documentation to begin with. I don't want to make this log message too long.
swiatekm
force-pushed
the
feat/sumologicextension/collector-guid
branch
from
ec50e64 to
43fed5d
Compare
This ends up causing more problems than it solves. In most circumstances the hostname is unique, and where it isn't, the user should set the collector name explicitly. And just using the hostname makes the user experience in the majority of cases better.