Fix CodeSandbox functionality. #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan P. C. McQuen <[email protected]>
|
In the future there may be a way to specify an entry point besides using the For now there is some configuration, but nothing concerning the entry point: |
|
If we merge this, let's not delete the branch, because I am investigating a CodeSandbox issue with it: |
terryfritschSLT
approved these changes
Jul 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now you can drop our main URL into CodeSandbox and have an instantly hackable sandbox.
Only question is ... are we using the
mainproperty in our rootpackage.jsonfor anything? Because this PR has it pointing toCodeSandbox/index.js... I didn't see anindex.jsin our root folder, so I didn't think we were.Signed-off-by: Ryan P. C. McQuen [email protected]