Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: upgrade from node12 to node20 #44

Open
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

magmanu
Copy link

@magmanu magmanu commented May 24, 2024

Breaking changes

  • node20
  • Default artifact name now contains epoch to provent collision (eg. ZAProxy-sarif-report-1716559045)
  • Deprecation of local tests

Other changes

  • Bump dependencies
  • Update tests
  • Update README

Btw, hi! Just realised I have met you this year at Github Galaxy London :)
Ofc you won't remember, but keep on the good work with GHAS!

magmanu and others added 29 commits May 24, 2024 11:27
Bumps the npm_and_yarn group with 1 update in the / directory: [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse).


Updates `@babel/traverse` from 7.24.5 to 7.24.6
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.24.6/packages/babel-traverse)

---
updated-dependencies:
- dependency-name: "@babel/traverse"
  dependency-type: indirect
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <[email protected]>
…rn-04a9c7ffa6

build(deps-dev): bump @babel/traverse from 7.24.5 to 7.24.6 in the npm_and_yarn group across 1 directory
@magmanu magmanu changed the title fix!: upgrade node20 fix!: upgrade from node12 to node20 May 24, 2024
@magmanu magmanu changed the title fix!: upgrade from node12 to node20 feat!: upgrade from node12 to node20 May 24, 2024
@SvanBoxel
Copy link
Owner

Lovely work! Thank you so much for your contribution. It's been a while since I looked at this action so happy its still being used & updated. Could you check the actions log for build-test/test? I appears an error was introduced in the Run tests dynamically injecting branch name step.: https://github.com/SvanBoxel/zaproxy-to-ghas/actions/runs/9226160621/job/25389320860?pr=44#step:6:3

Btw, hi! Just realised I have met you this year at Github Galaxy London :)
Ofc you won't remember, but keep on the good work with GHAS!

How exciting! 🙌🏽 :octocat:

@magmanu
Copy link
Author

magmanu commented May 28, 2024

Could you check the actions log for build-test/test?

oh, I forgot to account for forks lol
will push a fix when I have some time this week :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants