Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure there is a clear divide between the two Bluetooth Data Transfer Modes #67

Open
pr1sm opened this issue Feb 27, 2018 · 0 comments
Labels
bug Something isn't working

Comments

@pr1sm
Copy link
Contributor

pr1sm commented Feb 27, 2018

There are several places where we branch and perform different behavior based on the transfer mode active (Bluetooth Classic, or Bluetooth Low Energy). Each place should be checked to make sure we are performing the correct behavior based on the mode being used.

That is, if we are using BLE for transferring data, any functions related to BC must have no effect. Similarly, if we are using BC for transferring data, any functions related to BLE must have no effect.

@pr1sm pr1sm added the bug Something isn't working label Feb 27, 2018
pr1sm added a commit that referenced this issue Mar 1, 2018
This commit fixes a bug that could occur when using CB transfers instead of MP. The sendData function runs at the correct time in all cases, but this is only required for MP transfers. During a CB transfer, this don't have a lasting effects, but does produce some red herring error messages. 

To fix this, a check was added to make sure we are performing a MP transfer before trying to send data.

Issue: #67
@pr1sm pr1sm changed the title Ensure there is a clear device between the two Bluetooth Data Transfer Modes Ensure there is a clear divide between the two Bluetooth Data Transfer Modes Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant