Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug - Images which have not been cropped do not get added to pdf. #85

Closed
aayushinigam opened this issue Jun 7, 2018 · 8 comments
Closed

Bug - Images which have not been cropped do not get added to pdf. #85

aayushinigam opened this issue Jun 7, 2018 · 8 comments
Labels
bug good first issue production

Comments

@aayushinigam
Copy link

Steps to produce the bug -

  1. Choose multiple images.
  2. Click on Crop Images option
  3. Crop only a few of them
  4. Create pdf
  5. Pdf is created only for those which have been cropped.Other images are discarded.
@ashish4321
Copy link

Can i work on it?

@Swati4star
Copy link
Owner

Sure. Go ahead 👍

@ashish4321
Copy link

Can you explain what has to be done?

@Swati4star
Copy link
Owner

  • Are you able to reproduce the issue? Follow the steps mentioned above.
  • Figure out why is it happening.

@Swati4star
Copy link
Owner

@ashish4321 Any updates? It's a cakewalk issue. Shouldn't take 5 days.

@ashish4321
Copy link

Which images to chose and how to crop the images?? I am not getting any idea?? Cn you pls help?? What has to be done and how?

@Swati4star
Copy link
Owner

Did you even download the app?
( Connect on slack. )

Swati4star added a commit that referenced this issue Jul 4, 2018
@Swati4star
Code Refactoring. Also fixes #58 and #85
ee94916
@Swati4star
Copy link
Owner

Fixed by ee94916

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue production
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Swati4star @aayushinigam @ashish4321