refactor: change plugin export from default to named #274
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describing the problem
If you import the plugin as directed in the docs you may encounter a console error like:
And you will be returned this if you log
dts
to the console:This PR closes #247.
Describing the solution
This PR modifies the export of the
plugin
function as a named export calleddts
rather thanexport default
.Using named exports is less likely to encounter these inconsistent importing patterns in the future.
This StackOverflow thread provides multiple reasons why named exports are a favourable pattern for ES6. This response compiles relevant articles expanding on the issue.
Describing changes to the package
This PR would change the way this package is imported into projects. It will be a breaking change as importing will now be: