-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate output without namespace #32
Conversation
If no namespace param is provided, output is generated without namespace
CI has failed, however on my Windows 10 machine, the test has failed too, but I see no difference between example/osm.ts and output artifacts/osm.ts (I compared the two files in VS Code, Compare contextual menu). So I'm unable to see what to change to make the test pass. |
Thanks for the patch! Take a look at https://github.com/abenhamdine/schemats/pull/2 , I fixed the CI issue |
DIff checking fix
Ah thx a lot, CI is green now 🎉 |
Nice! I'll merge this together with fix for #31 and release v1.0 |
IMHO a fix for #19 would be great for v1.0 (typescript users are sticklers for null checking these days 😉 ) |
Alright let's add that to the roadmap for v1.0 too . Let me know if you are pulling together a patch for any of those so we don't double the effort :) |
Merged in here 64143dd Thanks @abenhamdine |
Fixes #25
If namespace parameter is falsy (not provided or empty), don't generate anymore the namespace in the output file.
Sorry for the churn in artifact/osm.ts, I realized my indentation settings were different after having committed,