Skip to content
This repository has been archived by the owner on Jan 19, 2025. It is now read-only.

Weather command and some fixes #498

Merged
merged 8 commits into from
Dec 1, 2018
Merged

Weather command and some fixes #498

merged 8 commits into from
Dec 1, 2018

Conversation

metehus
Copy link
Member

@metehus metehus commented Nov 25, 2018

Weather command, Google Maps API, Dark Sky API and some fixes in some js doc

Closes #77

Fixes in the js documentation
@metehus metehus added type: fix Fixes a bug scope: commands New command(s) suggestion/addition scope: command-system Related to the command preprocessor system labels Nov 25, 2018
@pedrofracassi pedrofracassi removed the scope: command-system Related to the command preprocessor system label Nov 25, 2018
@jaxxibae
Copy link
Member

rfr?

@Doges Doges self-requested a review November 25, 2018 10:21
Doges
Doges previously requested changes Nov 25, 2018
Copy link
Member

@Doges Doges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore that

const CARD_Y_MARGIN = (HEIGHT - CARD_HEIGHT) * 0.5

const FONTS = (() => {
const MEME = Math.random() > 0.99 && '"Comic Sans MS"'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I SEE YOU

pedrofracassi
pedrofracassi previously approved these changes Nov 27, 2018
Copy link
Member

@pedrofracassi pedrofracassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should wait for @davipatury to review it, tho.

@pedrofracassi pedrofracassi mentioned this pull request Nov 27, 2018
src/apis/DarkSky.js Outdated Show resolved Hide resolved
src/apis/GoogleMaps.js Show resolved Hide resolved
src/commands/utility/weather.js Outdated Show resolved Hide resolved
src/commands/utility/weather.js Outdated Show resolved Hide resolved
src/structures/command/CommandContext.js Outdated Show resolved Hide resolved
src/utils/CanvasTemplates.js Outdated Show resolved Hide resolved
src/utils/CanvasTemplates.js Outdated Show resolved Hide resolved
src/utils/CanvasTemplates.js Outdated Show resolved Hide resolved
src/utils/CanvasTemplates.js Outdated Show resolved Hide resolved
src/utils/CanvasTemplates.js Outdated Show resolved Hide resolved
@davipatury
Copy link
Member

Before rework

bfr

After rework

aft

Most of changes were codewise.

@davipatury davipatury self-assigned this Dec 1, 2018
@Doges Doges self-requested a review December 1, 2018 21:27
Copy link
Member

@Doges Doges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@Doges Doges merged commit bbc0315 into dev Dec 1, 2018
@Doges Doges deleted the weather-command branch December 1, 2018 21:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: commands New command(s) suggestion/addition type: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weather command
5 participants