Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Sylius UI instead of Sonata event #187

Merged
merged 2 commits into from
Oct 22, 2020
Merged

Use Sylius UI instead of Sonata event #187

merged 2 commits into from
Oct 22, 2020

Conversation

Prometee
Copy link
Contributor

No description provided.

@Prometee Prometee requested a review from a team as a code owner October 15, 2020 15:42
Zales0123
Zales0123 reviewed Oct 22, 2020
View reviewed changes
Copy link
Member

@Zales0123 Zales0123 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 but the build failed due to some incompatibility with symplify/package-builder :/ The easiest way yo fix it will be adding a conflict, as proposed here

EDIT: It's already there #190 💃

@Zales0123 Zales0123 added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label Oct 22, 2020
@Prometee
Copy link
Contributor Author

@Zales0123 yep I already ping GSadee about it 😉

@GSadee GSadee merged commit b9f05de into Sylius:master Oct 22, 2020
@GSadee
Copy link
Member

GSadee commented Oct 22, 2020

Thanks, Francis! 🎉

@Prometee Prometee deleted the sylius-ui branch October 22, 2020 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zales0123 Zales0123 Zales0123 left review comments

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Prometee @GSadee @Zales0123