Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add conflict to ^8.3.25 of symplify/package-builder to fix the build #190

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Add conflict to ^8.3.25 of symplify/package-builder to fix the build #190

merged 1 commit into from
Oct 22, 2020

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Oct 22, 2020

Extracted commit of @Prometee from #186

@GSadee GSadee added the Maintenance Configurations, READMEs, releases, etc. label Oct 22, 2020
@GSadee GSadee requested a review from a team as a code owner October 22, 2020 09:13
@Prometee
Copy link
Contributor

I don't dig enough about the changes occurring into ECS but it seems that sylius/sylius is not using it anymore (not sure of this).
What's the plan for the futur of ECS into Sylius and Sylius's plugins ?

@GSadee
Copy link
Member Author

GSadee commented Oct 22, 2020

Hi @Prometee! To be honest, I have no opinion about using ECS in Sylius/Sylius repository, but this package is still valuable and we want to use them in plugins for sure

@GSadee GSadee merged commit b1dd092 into Sylius:master Oct 22, 2020
@GSadee GSadee deleted the fix-ecs branch October 22, 2020 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zales0123 Zales0123 Zales0123 approved these changes

Assignees
No one assigned
Labels
Maintenance Configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GSadee @Prometee @Zales0123