Fix Doctrine/Migrations configuration #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zales0123
force-pushed
the
fix-migrations-configuration
branch
from
c6fb173 to
ec2bb72
Compare
Zales0123
force-pushed
the
fix-migrations-configuration
branch
from
ec2bb72 to
333fbb0
Compare
GSadee
approved these changes
Nov 13, 2020
|
Thanks, Mateusz! 🎉 |
|
I would vote for tests as well |
GSadee
added a commit
to Sylius/RefundPlugin
that referenced
this pull request
Nov 13, 2020
This PR was merged into the 1.0-dev branch. Discussion ---------- The same as Sylius/InvoicingPlugin#195 Without this change, migrations are generated into the plugin's directory rather than `src/Migrations`. Commits ------- fe0deaa Fix Doctrine/Migrations configuration
GSadee
added a commit
to GSadee/RefundPlugin
that referenced
this pull request
Nov 13, 2020
This PR was merged into the 1.0-dev branch. Discussion ---------- The same as Sylius/InvoicingPlugin#195 Without this change, migrations are generated into the plugin's directory rather than `src/Migrations`. Commits ------- fe0deaa Fix Doctrine/Migrations configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #192
Without this change, migrations are generated into the plugin's directory rather than
src/Migrations. I'm wondering do we need/want to have a test for the proper migrations directory like in the PayPalPlugin? 🤷♂️